Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 867093004: Android: Fix potential null-ptr deref (Closed)

Created:
5 years, 10 months ago by no sievers
Modified:
5 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Fix potential null-ptr deref BrowserGpuChannelHostFactory::GetGpuChannel() can return NULL. In particular it already checks IsLost() and returns NULL if that is the case. BUG=445945 Committed: https://crrev.com/62e2fc7f7dd1d2f29c6299efa1535c8894d4cb4c Cr-Commit-Position: refs/heads/master@{#314683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
no sievers
ptal
5 years, 10 months ago (2015-02-04 23:07:57 UTC) #2
epennerAtGoogle
LGTM
5 years, 10 months ago (2015-02-04 23:10:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867093004/1
5 years, 10 months ago (2015-02-04 23:12:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 00:02:58 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:04:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62e2fc7f7dd1d2f29c6299efa1535c8894d4cb4c
Cr-Commit-Position: refs/heads/master@{#314683}

Powered by Google App Engine
This is Rietveld 408576698