src/mips64/code-stubs-mips64.cc - Issue 867093003: MIPS: convert compile-time checkable DCHECKs to STATIC_ASSERTs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/code-stubs-mips64.cc

Issue 867093003: MIPS: convert compile-time checkable DCHECKs to STATIC_ASSERTs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips64/code-stubs-mips64.cc

diff --git a/src/mips64/code-stubs-mips64.cc b/src/mips64/code-stubs-mips64.cc

index b4064ae733b6f0461c295b39adf90447ac74bb40..b0ef6c6aeffbe0e6255e50cb642b78b78dda8aa4 100644

--- a/src/mips64/code-stubs-mips64.cc

+++ b/src/mips64/code-stubs-mips64.cc

@@ -3993,7 +3993,7 @@ void NameDictionaryLookupStub::GenerateNegativeLookup(MacroAssembler* masm,

Operand(name->Hash() + NameDictionary::GetProbeOffset(i)));

// Scale the index by multiplying by the entry size.

- DCHECK(NameDictionary::kEntrySize == 3);

+ STATIC_ASSERT(NameDictionary::kEntrySize == 3);

__ dsll(at, index, 1);

__ Daddu(index, index, at); // index *= 3.

« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | no next file » | no next file with comments »