Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 867093003: MIPS: convert compile-time checkable DCHECKs to STATIC_ASSERTs. (Closed)

Created:
5 years, 11 months ago by balazs.kilvady
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: convert compile-time checkable DCHECKs to STATIC_ASSERTs. Port cc6c373e2a25ae5ab54ea0ff042230364ec1a21b BUG= Committed: https://crrev.com/21a465607d34b6951a79f077f4bece9a9b450fe2 Cr-Commit-Position: refs/heads/master@{#26248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 11 months ago (2015-01-23 11:00:04 UTC) #2
dusmil.imgtec
LGTM.
5 years, 11 months ago (2015-01-23 11:01:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867093003/1
5 years, 11 months ago (2015-01-23 11:29:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 12:00:10 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 12:00:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/21a465607d34b6951a79f077f4bece9a9b450fe2
Cr-Commit-Position: refs/heads/master@{#26248}

Powered by Google App Engine
This is Rietveld 408576698