Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Side by Side Diff: tools/testing/dart/browser_controller.dart

Issue 867083003: Restart IE 10 browser as we do with Android browsers on buildbot, to improve stability (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 library browser; 4 library browser;
5 5
6 import "dart:async"; 6 import "dart:async";
7 import "dart:convert" show LineSplitter, UTF8, JSON; 7 import "dart:convert" show LineSplitter, UTF8, JSON;
8 import "dart:core"; 8 import "dart:core";
9 import "dart:io"; 9 import "dart:io";
10 10
(...skipping 1136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1147 } 1147 }
1148 if (testQueue.isEmpty) return null; 1148 if (testQueue.isEmpty) return null;
1149 1149
1150 // We are currently terminating this browser, don't start a new test. 1150 // We are currently terminating this browser, don't start a new test.
1151 if (status.timeout) return null; 1151 if (status.timeout) return null;
1152 1152
1153 // Restart content_shell and dartium on Android if they have been 1153 // Restart content_shell and dartium on Android if they have been
1154 // running for longer than RESTART_BROWSER_INTERVAL. The tests have 1154 // running for longer than RESTART_BROWSER_INTERVAL. The tests have
1155 // had flaky timeouts, and this may help. 1155 // had flaky timeouts, and this may help.
1156 if ((browserName == 'ContentShellOnAndroid' || 1156 if ((browserName == 'ContentShellOnAndroid' ||
1157 browserName == 'DartiumOnAndroid' ) && 1157 browserName == 'DartiumOnAndroid' ||
1158 browserName == 'ie10') &&
1158 status.timeSinceRestart.elapsed > RESTART_BROWSER_INTERVAL) { 1159 status.timeSinceRestart.elapsed > RESTART_BROWSER_INTERVAL) {
1159 var id = status.browser.id; 1160 var id = status.browser.id;
1160 // Reset stopwatch so we don't trigger again before restarting. 1161 // Reset stopwatch so we don't trigger again before restarting.
1161 status.timeout = true; 1162 status.timeout = true;
1162 status.browser.close().then((_) { 1163 status.browser.close().then((_) {
1163 // We don't want to start a new browser if we are terminating. 1164 // We don't want to start a new browser if we are terminating.
1164 if (underTermination) return; 1165 if (underTermination) return;
1165 restartBrowser(id); 1166 restartBrowser(id);
1166 }); 1167 });
1167 // Don't send a test to the browser we are restarting. 1168 // Don't send a test to the browser we are restarting.
(...skipping 624 matching lines...) Expand 10 before | Expand all | Expand 10 after
1792 </div> 1793 </div>
1793 <div id="embedded_iframe_div" class="test box"> 1794 <div id="embedded_iframe_div" class="test box">
1794 <iframe style="width:100%;height:100%;" id="embedded_iframe"></iframe> 1795 <iframe style="width:100%;height:100%;" id="embedded_iframe"></iframe>
1795 </div> 1796 </div>
1796 </body> 1797 </body>
1797 </html> 1798 </html>
1798 """; 1799 """;
1799 return driverContent; 1800 return driverContent;
1800 } 1801 }
1801 } 1802 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698