Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 867063003: Revert of Re-re-enable the activation behavior of media elements (click to play/pause) (Closed)

Created:
5 years, 11 months ago by philipj_slow
Modified:
5 years, 11 months ago
Reviewers:
fs
CC:
blink-reviews, nessy, gasubic, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of Re-re-enable the activation behavior of media elements (click to play/pause) (patchset #2 id:20001 of https://codereview.chromium.org/829393004/) Reason for revert: On Android: 1. The entire video is now clickable, leading more often to ambigous touches and zooming. 2. When the controls are not visible, touching the video will both pause the video and show the controls, where they would previously only show the controls. Original issue's description: > Re-re-enable the activation behavior of media elements (click to play/pause) > > The previous attempt broke the overlay play button: > https://codereview.chromium.org/830183005/#msg15 > > Drop the changes to MediaControlOverlayPlayButtonElement and add a test. > > BUG=354746 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188233 TBR=fs@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=354746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -230 lines) Patch
D LayoutTests/media/activation-behavior.html View 1 chunk +0 lines, -111 lines 0 comments Download
D LayoutTests/media/activation-behavior-accesskey.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/media/activation-behavior-fullscreen.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/media/activation-behavior-shadow.html View 1 chunk +0 lines, -50 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
philipj_slow
Created Revert of Re-re-enable the activation behavior of media elements (click to play/pause)
5 years, 11 months ago (2015-01-23 09:48:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867063003/1
5 years, 11 months ago (2015-01-23 09:49:11 UTC) #2
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 09:49:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188869

Powered by Google App Engine
This is Rietveld 408576698