Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 867043003: [android] Remove libaddressinput Java widget. (Closed)

Created:
5 years, 10 months ago by please use gerrit instead
Modified:
5 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Remove libaddressinput Java widget. Android uses a custom UI with the cross-platform strings for address input. This is a re-land of http://crrev.com/890103002 with a minor alteration to fix Android GN build: do not build the validator on Android. TBR=estade@chromium.org BUG=454120 Committed: https://crrev.com/09b2e3445106cc029b3a8d7e2fce137a5375a8e2 Cr-Commit-Position: refs/heads/master@{#314414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -174 lines) Patch
D chrome/app/address_input_strings_android.grd View 1 chunk +0 lines, -66 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 chunk +1 line, -71 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
please use gerrit instead
FYI, TBR-ing because this is mostly identical reland.
5 years, 10 months ago (2015-02-03 21:06:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867043003/1
5 years, 10 months ago (2015-02-03 21:07:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 22:01:38 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 22:03:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09b2e3445106cc029b3a8d7e2fce137a5375a8e2
Cr-Commit-Position: refs/heads/master@{#314414}

Powered by Google App Engine
This is Rietveld 408576698