Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chromeos/dbus/shill_client_helper.h

Issue 867043002: In ShillClientHelper use a{sv} for property dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WriteStringDict -> AppendStringDict Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/shill_client_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_client_helper.h
diff --git a/chromeos/dbus/shill_client_helper.h b/chromeos/dbus/shill_client_helper.h
index a52fc222eae758b43c86d32bd1b97554f9f044db..e2795e4538ce6436408ba7d8b8176ca1f706ab69 100644
--- a/chromeos/dbus/shill_client_helper.h
+++ b/chromeos/dbus/shill_client_helper.h
@@ -141,15 +141,16 @@ class ShillClientHelper {
const dbus::ObjectProxy* object_proxy() const { return proxy_; }
- // Appends the value (basic types and string-to-string dictionary) to the
- // writer as a variant.
+ // Appends the value to the writer as a variant. If |value| is a Dictionary it
+ // will be written as a string -> varient dictionary, a{sv}. If |value| is a
+ // List then it must be a List of String values and is writen as type 'as'.
static void AppendValueDataAsVariant(dbus::MessageWriter* writer,
const base::Value& value);
- // Appends a string-to-variant dictionary to the writer.
- static void AppendServicePropertiesDictionary(
- dbus::MessageWriter* writer,
- const base::DictionaryValue& dictionary);
+ // Appends a string-to-variant dictionary to the writer as an '{sv}' array.
+ // Each value is written using AppendValueDataAsVariant.
+ static void AppendServicePropertiesDictionary(dbus::MessageWriter* writer,
+ const base::DictionaryValue&);
protected:
// Reference / Ownership management. If the number of active refs (observers
« no previous file with comments | « no previous file | chromeos/dbus/shill_client_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698