Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: ui/gfx/render_text_unittest.cc

Issue 867003002: Cache gfx::RenderText instances in views::Label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text_unittest.cc
diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc
index 542939ea3081369af9a50fdf080f3490eaa7d3d8..e96f36f5f6b62df93bd8c505d6973825f29fb70d 100644
--- a/ui/gfx/render_text_unittest.cc
+++ b/ui/gfx/render_text_unittest.cc
@@ -650,6 +650,25 @@ TEST_F(RenderTextTest, TruncatedCursorMovementRTL) {
RunMoveCursorLeftRightTest(render_text.get(), expected, CURSOR_RIGHT);
}
+TEST_F(RenderTextTest, AccessibleText) {
msw 2015/02/25 23:54:26 nit: update naming and comments below to reflect G
Jun Mukai 2015/02/26 01:40:25 This test case was also removed since the method w
+ scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
+ render_text->SetText(WideToUTF16(L"abcdefghi"));
+ EXPECT_EQ(WideToUTF16(L"abcdefghi"), render_text->GetAccessibleText());
+
+ // Elide the text. GetDisplayText() will return the elided text, but
+ // GetAccessibleText() should return the un-elided one.
+ render_text->SetElideBehavior(ELIDE_TAIL);
+ gfx::Size string_size = render_text->GetStringSize();
+ string_size.set_width(string_size.width() / 2);
+ render_text->SetDisplayRect(gfx::Rect(string_size));
+ EXPECT_NE(WideToUTF16(L"abcdefghi"), render_text->GetDisplayText());
+ EXPECT_EQ(WideToUTF16(L"abcdefghi"), render_text->GetAccessibleText());
+
+ // When obscured, GetAccessibleText() should not return the original value.
+ render_text->SetObscured(true);
+ EXPECT_EQ(WideToUTF16(L"*********"), render_text->GetAccessibleText());
+}
+
TEST_F(RenderTextTest, GetDisplayTextDirection) {
struct {
const wchar_t* text;

Powered by Google App Engine
This is Rietveld 408576698