ui/gfx/render_text_harfbuzz.cc - Issue 867003002: Cache gfx::RenderText instances in views::Label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 867003002: Cache gfx::RenderText instances in views::Label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup / re-upload Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index 67b02bf7d002a02509da144606b52f3622841171..d8429f1b469f6dc3e656fad965b75cf14cd9c8ec 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -653,6 +653,10 @@ const base::string16& RenderTextHarfBuzz::GetDisplayText() {

return text_elided() ? display_text() : layout_text();

}

+bool RenderTextHarfBuzz::MultilineSupported() const {

+ return true;

Size RenderTextHarfBuzz::GetStringSize() {

const SizeF size_f = GetStringSizeF();

return Size(std::ceil(size_f.width()), size_f.height());