ui/views/controls/textfield/textfield.cc - Issue 867003002: Cache gfx::RenderText instances in views::Label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 867003002: Cache gfx::RenderText instances in views::Label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 271f29a4b1f6903d3c3c53c17d04cb9342b3ea84..2934ad5ea30b9273532c70a312b5211fd1e42f43 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -1641,7 +1641,7 @@ void Textfield::AccessibilitySetValue(const base::string16& new_value) {

void Textfield::UpdateBackgroundColor() {

const SkColor color = GetBackgroundColor();

set_background(Background::CreateSolidBackground(color));

- GetRenderText()->set_background_is_transparent(SkColorGetA(color) != 0xFF);

+ GetRenderText()->set_subpixel_rendering_enabled(SkColorGetA(color) == 0xFF);

SchedulePaint();

}

« ui/gfx/render_text.h ('K') | « ui/views/controls/label_unittest.cc ('k') | no next file » | no next file with comments »