Cache gfx::RenderText instances in views::Label.

ui/app_list/views/app_list_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_item_view.h"
 
 #include <algorithm>
 
 #include "base/profiler/scoped_tracker.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 170 matching lines @@
       layer()->SetTransform(gfx::GetScaleTransform(
           bounds.CenterPoint(),
           kDraggingIconScale));
       break;
     }
     case UI_STATE_DROPPING_IN_FOLDER:
       break;
   }
 #endif  // !OS_WIN
 
+  SetTitleSubpixelAA();
   SchedulePaint();
 }
 
 void AppListItemView::SetTouchDragging(bool touch_dragging) {
   if (touch_dragging_ == touch_dragging)
     return;
 
   touch_dragging_ = touch_dragging;
   SetState(STATE_NORMAL);
   SetUIState(touch_dragging_ ? UI_STATE_DRAGGING : UI_STATE_NORMAL);
 }
 
 void AppListItemView::OnMouseDragTimer() {
   DCHECK(apps_grid_view_->IsDraggedView(this));
   SetUIState(UI_STATE_DRAGGING);
 }
 
 void AppListItemView::SetTitleSubpixelAA() {
   // TODO(tapted): Enable AA for folders as well, taking care to play nice with
   // the folder bubble animation.
   bool enable_aa = !is_in_folder_ && ui_state_ == UI_STATE_NORMAL &&
                    !is_highlighted_ && !apps_grid_view_->IsSelectedView(this) &&
                    !apps_grid_view_->IsAnimatingView(this);
 
-  bool currently_enabled = title_->background() != NULL;
-  if (currently_enabled == enable_aa)
-    return;
-
+  title_->SetSubpixelRenderingEnabled(enable_aa);
   if (enable_aa) {
     title_->SetBackgroundColor(app_list::kLabelBackgroundColor);
     title_->set_background(views::Background::CreateSolidBackground(
         app_list::kLabelBackgroundColor));
   } else {
     // In other cases, keep the background transparent to ensure correct
     // interactions with animations. This will temporarily disable subpixel AA.
     title_->SetBackgroundColor(0);
     title_->set_background(NULL);
   }
@@ skipping 41 matching lines @@
   // Use full name for accessibility.
   SetAccessibleName(
       is_folder_ ? l10n_util::GetStringFUTF16(
                        IDS_APP_LIST_FOLDER_BUTTON_ACCESSIBILE_NAME, full_name)
                  : full_name);
   Layout();
 }
 
 void AppListItemView::SetItemIsHighlighted(bool is_highlighted) {
   is_highlighted_ = is_highlighted;
+  SetTitleSubpixelAA();
   SchedulePaint();
 }
 
 void AppListItemView::SetItemIsInstalling(bool is_installing) {
   is_installing_ = is_installing;
   if (ui_state_ == UI_STATE_NORMAL) {
     title_->SetVisible(!is_installing);
     progress_bar_->SetVisible(is_installing);
   }
+  SetTitleSubpixelAA();
   SchedulePaint();
 }
 
 void AppListItemView::SetItemPercentDownloaded(int percent_downloaded) {
   // A percent_downloaded() of -1 can mean it's not known how much percent is
   // completed, or the download hasn't been marked complete, as is the case
   // while an extension is being installed after being downloaded.
   if (percent_downloaded == -1)
     return;
   progress_bar_->SetValue(percent_downloaded / 100.0);
@@ skipping 26 matching lines @@
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/431326 is fixed.
   tracked_objects::ScopedTracker tracking_profile3(
       FROM_HERE_WITH_EXPLICIT_FUNCTION("431326 AppListItemView::Layout3"));
 
   gfx::Rect title_bounds(rect.x() + (rect.width() - title_size.width()) / 2,
                          y + kGridIconDimension + kIconTitleSpacing,
                          title_size.width(),
                          title_size.height());
   title_bounds.Intersect(rect);
   title_->SetBoundsRect(title_bounds);
+  SetTitleSubpixelAA();
 
   gfx::Rect progress_bar_bounds(progress_bar_->GetPreferredSize());
   progress_bar_bounds.set_x(GetContentsBounds().x() +
                             kProgressBarHorizontalPadding);
   progress_bar_bounds.set_y(title_bounds.y());
   progress_bar_->SetBoundsRect(progress_bar_bounds);
 }
 
-void AppListItemView::SchedulePaintInRect(const gfx::Rect& r) {
-  SetTitleSubpixelAA();
-  views::CustomButton::SchedulePaintInRect(r);
-}
-
 void AppListItemView::OnPaint(gfx::Canvas* canvas) {
   if (apps_grid_view_->IsDraggedView(this))
     return;
 
   gfx::Rect rect(GetContentsBounds());
   if (apps_grid_view_->IsSelectedView(this)) {
     canvas->FillRect(rect, kSelectedColor);
   } else if (is_highlighted_ && !is_installing_) {
     canvas->FillRect(rect, kHighlightedColor);
     return;
@@ skipping 41 matching lines @@
     // keyboard selection; for mouse hover, keyboard selection takes precedence.
     if (!apps_grid_view_->IsSelectedView(this) || state() == STATE_PRESSED)
       SetItemIsHighlighted(true);
     title_->SetEnabledColor(kGridTitleHoverColor);
   } else {
     SetItemIsHighlighted(false);
     if (item_weak_)
       item_weak_->set_highlighted(false);
     title_->SetEnabledColor(kGridTitleColor);
   }
-  title_->Invalidate();
+  SetTitleSubpixelAA();
 }
 
 bool AppListItemView::ShouldEnterPushedState(const ui::Event& event) {
   // Don't enter pushed state for ET_GESTURE_TAP_DOWN so that hover gray
   // background does not show up during scroll.
   if (event.type() == ui::ET_GESTURE_TAP_DOWN)
     return false;
 
   return views::CustomButton::ShouldEnterPushedState(event);
 }
@@ skipping 169 matching lines @@
   SetItemPercentDownloaded(item_weak_->percent_downloaded());
 }
 
 void AppListItemView::ItemBeingDestroyed() {
   DCHECK(item_weak_);
   item_weak_->RemoveObserver(this);
   item_weak_ = NULL;
 }
 
 }  // namespace app_list