Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: components/password_manager/core/browser/test_password_store.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Second fix of the rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/test_password_store.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/test_password_store.cc
diff --git a/components/password_manager/core/browser/test_password_store.cc b/components/password_manager/core/browser/test_password_store.cc
index 678f7c7520e0faa1a5990e86165ffa3b2afe4c9e..f38f8ed3ad188d34df61ad37fd047cf23f9d7089 100644
--- a/components/password_manager/core/browser/test_password_store.cc
+++ b/components/password_manager/core/browser/test_password_store.cc
@@ -46,12 +46,12 @@ bool TestPasswordStore::FormsAreEquivalent(const autofill::PasswordForm& lhs,
}
void TestPasswordStore::GetAutofillableLoginsImpl(
- PasswordStore::GetLoginsRequest* request) {
- for (auto& forms_for_realm : stored_passwords_) {
+ scoped_ptr<GetLoginsRequest> request) {
+ for (const auto& forms_for_realm : stored_passwords_) {
for (const autofill::PasswordForm& form : forms_for_realm.second)
request->result()->push_back(new autofill::PasswordForm(form));
}
- ForwardLoginsResult(request);
+ ForwardLoginsResult(request.Pass());
}
PasswordStoreChangeList TestPasswordStore::AddLoginImpl(
@@ -107,6 +107,10 @@ void TestPasswordStore::GetLoginsImpl(
runner.Run(matched_forms.Pass());
}
+void TestPasswordStore::ReportMetricsImpl(const std::string& sync_username,
+ bool custom_passphrase_sync_enabled) {
+}
+
PasswordStoreChangeList TestPasswordStore::RemoveLoginsCreatedBetweenImpl(
base::Time begin,
base::Time end) {
@@ -121,6 +125,10 @@ PasswordStoreChangeList TestPasswordStore::RemoveLoginsSyncedBetweenImpl(
return changes;
}
+void TestPasswordStore::GetBlacklistLoginsImpl(
+ scoped_ptr<GetLoginsRequest> request) {
+}
+
bool TestPasswordStore::FillAutofillableLogins(
ScopedVector<autofill::PasswordForm>* forms) {
return true;
« no previous file with comments | « components/password_manager/core/browser/test_password_store.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698