components/password_manager/core/browser/stub_password_manager_client.cc - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Second fix of the rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/stub_password_manager_client.h ('k') | components/password_manager/core/browser/test_password_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.cc

diff --git a/components/password_manager/core/browser/stub_password_manager_client.cc b/components/password_manager/core/browser/stub_password_manager_client.cc

index d8a63eca54717cbf39574c8e71492095273330a5..e2d2d9a85aa9fd9644a718a9d2a69b95c2a8e9c3 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.cc

+++ b/components/password_manager/core/browser/stub_password_manager_client.cc

@@ -36,14 +36,9 @@ bool StubPasswordManagerClient::PromptUserToSavePassword(

}

bool StubPasswordManagerClient::PromptUserToChooseCredentials(

- const std::vector<autofill::PasswordForm*>& local_forms,

- const std::vector<autofill::PasswordForm*>& federated_forms,

+ ScopedVector<autofill::PasswordForm> local_forms,

+ ScopedVector<autofill::PasswordForm> federated_forms,

base::Callback<void(const password_manager::CredentialInfo&)> callback) {

- // Take ownership of all the password form objects in the forms vectors.

- ScopedVector<autofill::PasswordForm> local_entries;

- local_entries.assign(local_forms.begin(), local_forms.end());

- ScopedVector<autofill::PasswordForm> federated_entries;

- federated_entries.assign(federated_forms.begin(), federated_forms.end());

return false;

}