components/password_manager/core/browser/password_store_consumer.h - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_consumer.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Second fix of the rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store.cc ('k') | components/password_manager/core/browser/password_store_default.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_consumer.h

diff --git a/components/password_manager/core/browser/password_store_consumer.h b/components/password_manager/core/browser/password_store_consumer.h

index c9237778f4f319c2116d7f9d8dde191d9fb571c5..1ffdae3c871694263fec69204227d68ea93ac8c9 100644

--- a/components/password_manager/core/browser/password_store_consumer.h

+++ b/components/password_manager/core/browser/password_store_consumer.h

@@ -7,6 +7,7 @@

#include <vector>

+#include "base/memory/scoped_vector.h"

#include "base/task/cancelable_task_tracker.h"

namespace autofill {

@@ -24,11 +25,9 @@ class PasswordStoreConsumer {

public:

PasswordStoreConsumer();

- // Called when the request is finished. If there are no results, it is called

- // with an empty vector.

- // Note: The implementation owns all PasswordForms in the vector.

+ // Called when the request is finished, with the associated |results|.

virtual void OnGetPasswordStoreResults(

- const std::vector<autofill::PasswordForm*>& results) = 0;

+ ScopedVector<autofill::PasswordForm> results) = 0;

// The base::CancelableTaskTracker can be used for cancelling the

// tasks associated with the consumer.