components/password_manager/content/browser/credential_manager_password_form_manager.cc - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_password_form_manager.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Second fix of the rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_password_form_manager.h ('k') | components/password_manager/core/browser/mock_password_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_password_form_manager.cc

diff --git a/components/password_manager/content/browser/credential_manager_password_form_manager.cc b/components/password_manager/content/browser/credential_manager_password_form_manager.cc

index 0bea2826d527bb19c19863593eafcca21f6fe5c9..66539bb20b67e466017e2a1f9caf1f9e32442709 100644

--- a/components/password_manager/content/browser/credential_manager_password_form_manager.cc

+++ b/components/password_manager/content/browser/credential_manager_password_form_manager.cc

@@ -31,8 +31,8 @@ CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {

}

void CredentialManagerPasswordFormManager::OnGetPasswordStoreResults(

- const std::vector<PasswordForm*>& results) {

- PasswordFormManager::OnGetPasswordStoreResults(results);

+ ScopedVector<autofill::PasswordForm> results) {

+ PasswordFormManager::OnGetPasswordStoreResults(results.Pass());

// Mark the form as "preferred", as we've been told by the API that this is

// indeed the credential set that the user used to sign into the site.