chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Second fix of the rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/passwords_helper.cc ('k') | chrome/browser/ui/passwords/password_manager_presenter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

diff --git a/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc b/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

index 2ff5af78aea4fd49acc151a34ac05564aac7f5b7..4e536adcf3d5fdfe357505ca8ee04fb4dd0cb610 100644

--- a/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

+++ b/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

@@ -12,7 +12,6 @@

using passwords_helper::AddLogin;

using passwords_helper::CreateTestPasswordForm;

-using passwords_helper::GetLogins;

using passwords_helper::GetPasswordCount;

using passwords_helper::GetPasswordStore;

using passwords_helper::UpdateLogin;

@@ -50,12 +49,11 @@ void PasswordsSyncPerfTest::AddLogins(int profile, int num_logins) {

}

void PasswordsSyncPerfTest::UpdateLogins(int profile) {

- std::vector<autofill::PasswordForm> logins;

- GetLogins(GetPasswordStore(profile), logins);

- for (std::vector<autofill::PasswordForm>::iterator it = logins.begin();

- it != logins.end(); ++it) {

- (*it).password_value = base::ASCIIToUTF16(NextPassword());

- UpdateLogin(GetPasswordStore(profile), (*it));

+ ScopedVector<autofill::PasswordForm> logins =

+ passwords_helper::GetLogins(GetPasswordStore(profile));

+ for (autofill::PasswordForm* login : logins) {

+ login->password_value = base::ASCIIToUTF16(NextPassword());

+ UpdateLogin(GetPasswordStore(profile), *login);

}