Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Second fix of the rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index a69d75cc400baba6de89d137f20963f192f4d326..a6b71a5bf2b6f53ab87ed32342a80749dd4ad219 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -208,19 +208,13 @@ bool ChromePasswordManagerClient::PromptUserToSavePassword(
}
bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
- const std::vector<autofill::PasswordForm*>& local_forms,
- const std::vector<autofill::PasswordForm*>& federated_forms,
+ ScopedVector<autofill::PasswordForm> local_forms,
+ ScopedVector<autofill::PasswordForm> federated_forms,
base::Callback<void(const password_manager::CredentialInfo&)> callback) {
- // Take ownership of all the password form objects in the forms vectors.
- ScopedVector<autofill::PasswordForm> local_entries;
- local_entries.assign(local_forms.begin(), local_forms.end());
- ScopedVector<autofill::PasswordForm> federated_entries;
- federated_entries.assign(federated_forms.begin(), federated_forms.end());
-
ManagePasswordsUIController* manage_passwords_ui_controller =
ManagePasswordsUIController::FromWebContents(web_contents());
return manage_passwords_ui_controller->OnChooseCredentials(
- local_entries.Pass(), federated_entries.Pass(), callback);
+ local_forms.Pass(), federated_forms.Pass(), callback);
}
void ChromePasswordManagerClient::AutomaticPasswordSave(
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.h ('k') | chrome/browser/password_manager/password_store_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698