components/password_manager/core/browser/stub_password_manager_client.h - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Just rebased on mkwst's changes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_store_unittest.cc ('K') | « components/password_manager/core/browser/password_store_unittest.cc ('k') | components/password_manager/core/browser/stub_password_manager_client.cc » ('j') | components/password_manager/core/browser/test_password_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.h

diff --git a/components/password_manager/core/browser/stub_password_manager_client.h b/components/password_manager/core/browser/stub_password_manager_client.h

index 256f7d57262f580e935774b5224e37de9ad1bac1..db96ce91c538e2a81a5978727e3d2f0ff70b782e 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.h

+++ b/components/password_manager/core/browser/stub_password_manager_client.h

@@ -25,8 +25,8 @@ class StubPasswordManagerClient : public PasswordManagerClient {

bool PromptUserToSavePassword(

scoped_ptr<PasswordFormManager> form_to_save) override;

bool PromptUserToChooseCredentials(

- const std::vector<autofill::PasswordForm*>& local_forms,

- const std::vector<autofill::PasswordForm*>& federated_forms,

+ ScopedVector<autofill::PasswordForm> local_forms,

+ ScopedVector<autofill::PasswordForm> federated_forms,

base::Callback<void(const password_manager::CredentialInfo&)> callback)

override;