GetLoginsRequest: Use ScopedVector to express ownership of forms

chrome/browser/password_manager/password_store_mac.cc

Index: chrome/browser/password_manager/password_store_mac.cc
diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc
index 45875a1d33c84659561ab9a28aa71d1ea74fc689..5052c21707baf25b1a1b24daa932acc3b8cb8cdc 100644
--- a/chrome/browser/password_manager/password_store_mac.cc
+++ b/chrome/browser/password_manager/password_store_mac.cc
@@ -1087,18 +1087,20 @@ void PasswordStoreMac::GetLoginsImpl(
   callback_runner.Run(matched_forms.Pass());
 }
 
-void PasswordStoreMac::GetBlacklistLoginsImpl(GetLoginsRequest* request) {
+void PasswordStoreMac::GetBlacklistLoginsImpl(
+    scoped_ptr<PasswordStore::GetLoginsRequest> request) {
   ScopedVector<autofill::PasswordForm> obtained_forms;

[vasilii, 2015/02/09 10:08:34]

In PasswordStoreDefault you have DCHECK(request->result().empty()); here and
below.

[vabr (Chromium), 2015/02/09 11:36:06]

Done.

   FillBlacklistLogins(&obtained_forms);

[vasilii, 2015/02/09 10:08:35]

FillBlacklistLogins(request->result())?

[vabr (Chromium), 2015/02/09 11:36:06]

Done.

   request->result()->swap(obtained_forms.get());
-  ForwardLoginsResult(request);
+  ForwardLoginsResult(request.Pass());
 }
 
-void PasswordStoreMac::GetAutofillableLoginsImpl(GetLoginsRequest* request) {
+void PasswordStoreMac::GetAutofillableLoginsImpl(
+    scoped_ptr<PasswordStore::GetLoginsRequest> request) {
   ScopedVector<autofill::PasswordForm> obtained_forms;
   FillAutofillableLogins(&obtained_forms);
   request->result()->swap(obtained_forms.get());
-  ForwardLoginsResult(request);
+  ForwardLoginsResult(request.Pass());
 }
 
 bool PasswordStoreMac::FillAutofillableLogins(