Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Fix Mac unittest Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/stub_password_manager_client.cc
diff --git a/components/password_manager/core/browser/stub_password_manager_client.cc b/components/password_manager/core/browser/stub_password_manager_client.cc
index d8a63eca54717cbf39574c8e71492095273330a5..e2d2d9a85aa9fd9644a718a9d2a69b95c2a8e9c3 100644
--- a/components/password_manager/core/browser/stub_password_manager_client.cc
+++ b/components/password_manager/core/browser/stub_password_manager_client.cc
@@ -36,14 +36,9 @@ bool StubPasswordManagerClient::PromptUserToSavePassword(
}
bool StubPasswordManagerClient::PromptUserToChooseCredentials(
- const std::vector<autofill::PasswordForm*>& local_forms,
- const std::vector<autofill::PasswordForm*>& federated_forms,
+ ScopedVector<autofill::PasswordForm> local_forms,
+ ScopedVector<autofill::PasswordForm> federated_forms,
base::Callback<void(const password_manager::CredentialInfo&)> callback) {
- // Take ownership of all the password form objects in the forms vectors.
- ScopedVector<autofill::PasswordForm> local_entries;
- local_entries.assign(local_forms.begin(), local_forms.end());
- ScopedVector<autofill::PasswordForm> federated_entries;
- federated_entries.assign(federated_forms.begin(), federated_forms.end());
return false;
}

Powered by Google App Engine
This is Rietveld 408576698