GetLoginsRequest: Use ScopedVector to express ownership of forms

chrome/browser/sync/test/integration/passwords_helper.h

Index: chrome/browser/sync/test/integration/passwords_helper.h
diff --git a/chrome/browser/sync/test/integration/passwords_helper.h b/chrome/browser/sync/test/integration/passwords_helper.h
index 2ce1f7ddd3f895dbe13e28b1819028d94fad9ad6..488070ad9925f7475ce5561fc0b093196bf3057d 100644
--- a/chrome/browser/sync/test/integration/passwords_helper.h
+++ b/chrome/browser/sync/test/integration/passwords_helper.h
@@ -7,6 +7,7 @@
 
 #include <vector>
 
+#include "base/memory/scoped_vector.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
@@ -29,11 +30,10 @@ void AddLogin(password_manager::PasswordStore* store,
 void UpdateLogin(password_manager::PasswordStore* store,
                  const autofill::PasswordForm& form);
 
-// Searches |store| for all logins matching a fake signon realm used only by
-// LivePasswordsSyncTest and adds the results to |matches|. Note that the
-// caller is responsible for deleting the forms added to |matches|.
-void GetLogins(password_manager::PasswordStore* store,
-               std::vector<autofill::PasswordForm>& matches);
+// Returns all logins from |store| matching a fake signon realm used only by
+// LivePasswordsSyncTest.

[vasilii, 2015/02/05 19:23:27]

LivePasswordsSyncTest exists only in this comment :-)

[vabr (Chromium), 2015/02/06 14:16:05]

You are right. Seems like it has been renamed to PasswordsSyncPerfTest.
Done.

+ScopedVector<autofill::PasswordForm> GetLogins(
+    password_manager::PasswordStore* store);
 
 // Removes the login held in |form| from the password store |store|.  This
 // method blocks until the operation is complete.