chrome/browser/password_manager/chrome_password_manager_client.h - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Fix Mac unittest Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | chrome/browser/password_manager/password_store_mac_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.h

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h

index 98e9f1bb56ec47ecd0041638ea232794affb7d06..4e19a55178d32baa6dc769cad63c7dcfe788b957 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.h

+++ b/chrome/browser/password_manager/chrome_password_manager_client.h

@@ -53,10 +53,10 @@ class ChromePasswordManagerClient

bool PromptUserToSavePassword(

scoped_ptr<password_manager::PasswordFormManager> form_to_save) override;

bool PromptUserToChooseCredentials(

- const std::vector<autofill::PasswordForm*>& local_forms,

- const std::vector<autofill::PasswordForm*>& federated_forms,

- base::Callback<void(const password_manager::CredentialInfo&)>

- callback) override;

+ ScopedVector<autofill::PasswordForm> local_forms,

+ ScopedVector<autofill::PasswordForm> federated_forms,

+ base::Callback<void(const password_manager::CredentialInfo&)> callback)

+ override;

void AutomaticPasswordSave(scoped_ptr<password_manager::PasswordFormManager>

saved_form_manager) override;

void PasswordWasAutofilled(