components/password_manager/core/browser/test_password_store.h - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/test_password_store.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Rebased Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_store_unittest.cc ('K') | « components/password_manager/core/browser/stub_password_manager_client.cc ('k') | components/password_manager/core/browser/test_password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/test_password_store.h

diff --git a/components/password_manager/core/browser/test_password_store.h b/components/password_manager/core/browser/test_password_store.h

index dd549aa8dc4ee92fd18009d150e59ce735f4ed02..5490eb00b1ce353d1d18b118479281c391ef85db 100644

--- a/components/password_manager/core/browser/test_password_store.h

+++ b/components/password_manager/core/browser/test_password_store.h

@@ -50,8 +50,7 @@ class TestPasswordStore : public PasswordStore {

void GetLoginsImpl(const autofill::PasswordForm& form,

PasswordStore::AuthorizationPromptPolicy prompt_policy,

const ConsumerCallbackRunner& runner) override;

- void GetAutofillableLoginsImpl(

- PasswordStore::GetLoginsRequest* request) override;

+ void GetAutofillableLoginsImpl(scoped_ptr<GetLoginsRequest> request) override;

// Unused portions of PasswordStore interface

void ReportMetricsImpl(const std::string& sync_username,

@@ -62,8 +61,7 @@ class TestPasswordStore : public PasswordStore {

PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(

base::Time delete_begin,

base::Time delete_end) override;

- void GetBlacklistLoginsImpl(

- PasswordStore::GetLoginsRequest* request) override {}

+ void GetBlacklistLoginsImpl(scoped_ptr<GetLoginsRequest> request) override {}

bool FillAutofillableLogins(

ScopedVector<autofill::PasswordForm>* forms) override;

bool FillBlacklistLogins(