chrome/browser/ui/passwords/password_manager_presenter.h - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/password_manager_presenter.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Rebased Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_x_unittest.cc ('K') | « chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc ('k') | chrome/browser/ui/passwords/password_manager_presenter.cc » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/password_manager_presenter.h

diff --git a/chrome/browser/ui/passwords/password_manager_presenter.h b/chrome/browser/ui/passwords/password_manager_presenter.h

index 52523cf000bead5a576da0e5e6f6b0b4513952e5..522ad12da7a52413d1eaf4ccdd9514651eb0f308 100644

--- a/chrome/browser/ui/passwords/password_manager_presenter.h

+++ b/chrome/browser/ui/passwords/password_manager_presenter.h

@@ -94,8 +94,7 @@ class PasswordManagerPresenter

void Populate() override;

// Send the password store's reply back to the handler.

- void OnGetPasswordStoreResults(

- const std::vector<autofill::PasswordForm*>& results) override;

+ void OnGetPasswordStoreResults() override;

};

// A short class to mediate requests to the password store for exceptions.

@@ -107,8 +106,7 @@ class PasswordManagerPresenter

void Populate() override;

// Send the password store's reply back to the handler.

- void OnGetPasswordStoreResults(

- const std::vector<autofill::PasswordForm*>& results) override;

+ void OnGetPasswordStoreResults() override;

};

// Password store consumer for populating the password list and exceptions.