GetLoginsRequest: Use ScopedVector to express ownership of forms

chrome/browser/password_manager/password_store_x.cc

Index: chrome/browser/password_manager/password_store_x.cc
diff --git a/chrome/browser/password_manager/password_store_x.cc b/chrome/browser/password_manager/password_store_x.cc
index fa5c7b03516566ea274e52956d630697ca1e4c06..b1cbc9cb06fd3609f332426088c4eedbb7ffb436 100644
--- a/chrome/browser/password_manager/password_store_x.cc
+++ b/chrome/browser/password_manager/password_store_x.cc
@@ -157,39 +157,41 @@ void PasswordStoreX::GetLoginsImpl(
   callback_runner.Run(matched_forms.Pass());
 }
 
-void PasswordStoreX::GetAutofillableLoginsImpl(GetLoginsRequest* request) {
+void PasswordStoreX::GetAutofillableLoginsImpl(
+    scoped_ptr<PasswordStore::GetLoginsRequest> request) {
   CheckMigration();
   ScopedVector<autofill::PasswordForm> obtained_forms;
   if (use_native_backend() &&
       backend_->GetAutofillableLogins(&obtained_forms)) {
     request->result()->swap(obtained_forms.get());

[vasilii, 2015/02/03 19:22:16]

It's better to do whatever we want with |obtained_forms| and swap in the last
line.

[vabr (Chromium), 2015/02/04 16:13:44]

I share that sentiment. :)
Done.

-    SortLoginsByOrigin(request->result());
+    SortLoginsByOrigin(&request->result()->get());
     // See GetLoginsImpl() for why we disallow fallback conditionally here.
     if (request->result()->size() > 0)
       allow_fallback_ = false;
   } else if (allow_default_store()) {
-    PasswordStoreDefault::GetAutofillableLoginsImpl(request);
+    PasswordStoreDefault::GetAutofillableLoginsImpl(request.Pass());
     return;
   }
   // The consumer will be left hanging unless we reply.
-  ForwardLoginsResult(request);
+  ForwardLoginsResult(request.Pass());
 }
 
-void PasswordStoreX::GetBlacklistLoginsImpl(GetLoginsRequest* request) {
+void PasswordStoreX::GetBlacklistLoginsImpl(
+    scoped_ptr<PasswordStore::GetLoginsRequest> request) {
   CheckMigration();
   ScopedVector<autofill::PasswordForm> obtained_forms;
   if (use_native_backend() && backend_->GetBlacklistLogins(&obtained_forms)) {
     request->result()->swap(obtained_forms.get());
-    SortLoginsByOrigin(request->result());
+    SortLoginsByOrigin(&request->result()->get());

[vasilii, 2015/02/03 19:22:16]

See above.

[vabr (Chromium), 2015/02/04 16:13:44]

Done.

     // See GetLoginsImpl() for why we disallow fallback conditionally here.
     if (request->result()->size() > 0)
       allow_fallback_ = false;
   } else if (allow_default_store()) {
-    PasswordStoreDefault::GetBlacklistLoginsImpl(request);
+    PasswordStoreDefault::GetBlacklistLoginsImpl(request.Pass());
     return;
   }
   // The consumer will be left hanging unless we reply.
-  ForwardLoginsResult(request);
+  ForwardLoginsResult(request.Pass());
 }
 
 bool PasswordStoreX::FillAutofillableLogins(