Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: components/password_manager/content/browser/credential_manager_password_form_manager.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Second fix of the rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/content/browser/credential_manager_passwor d_form_manager.h" 5 #include "components/password_manager/content/browser/credential_manager_passwor d_form_manager.h"
6 6
7 #include "components/autofill/core/common/password_form.h" 7 #include "components/autofill/core/common/password_form.h"
8 #include "components/password_manager/content/browser/credential_manager_dispatc her.h" 8 #include "components/password_manager/content/browser/credential_manager_dispatc her.h"
9 #include "components/password_manager/core/browser/password_manager_client.h" 9 #include "components/password_manager/core/browser/password_manager_client.h"
10 #include "components/password_manager/core/browser/password_store.h" 10 #include "components/password_manager/core/browser/password_store.h"
(...skipping 13 matching lines...) Expand all
24 observed_form, 24 observed_form,
25 true), 25 true),
26 dispatcher_(dispatcher) { 26 dispatcher_(dispatcher) {
27 FetchMatchingLoginsFromPasswordStore(PasswordStore::DISALLOW_PROMPT); 27 FetchMatchingLoginsFromPasswordStore(PasswordStore::DISALLOW_PROMPT);
28 } 28 }
29 29
30 CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() { 30 CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {
31 } 31 }
32 32
33 void CredentialManagerPasswordFormManager::OnGetPasswordStoreResults( 33 void CredentialManagerPasswordFormManager::OnGetPasswordStoreResults(
34 const std::vector<PasswordForm*>& results) { 34 ScopedVector<autofill::PasswordForm> results) {
35 PasswordFormManager::OnGetPasswordStoreResults(results); 35 PasswordFormManager::OnGetPasswordStoreResults(results.Pass());
36 36
37 // Mark the form as "preferred", as we've been told by the API that this is 37 // Mark the form as "preferred", as we've been told by the API that this is
38 // indeed the credential set that the user used to sign into the site. 38 // indeed the credential set that the user used to sign into the site.
39 PasswordForm provisionally_saved_form(observed_form()); 39 PasswordForm provisionally_saved_form(observed_form());
40 provisionally_saved_form.preferred = true; 40 provisionally_saved_form.preferred = true;
41 ProvisionallySave(provisionally_saved_form, IGNORE_OTHER_POSSIBLE_USERNAMES); 41 ProvisionallySave(provisionally_saved_form, IGNORE_OTHER_POSSIBLE_USERNAMES);
42 dispatcher_->OnProvisionalSaveComplete(); 42 dispatcher_->OnProvisionalSaveComplete();
43 } 43 }
44 44
45 } // namespace password_manager 45 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698