GetLoginsRequest: Use ScopedVector to express ownership of forms

components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/credential_manager_dispatcher.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/testing_pref_service.h"
@@ skipping 41 matching lines @@
   PrefService* GetPrefs() override { return &prefs_; }
 
   bool PromptUserToSavePassword(
       scoped_ptr<password_manager::PasswordFormManager> manager) override {
     did_prompt_user_to_save_ = true;
     manager_.reset(manager.release());
     return true;
   }
 
   bool PromptUserToChooseCredentials(
-      const std::vector<autofill::PasswordForm*>& local_forms,
-      const std::vector<autofill::PasswordForm*>& federated_forms,
+      ScopedVector<autofill::PasswordForm> local_forms,
+      ScopedVector<autofill::PasswordForm> federated_forms,
       base::Callback<void(const password_manager::CredentialInfo&)> callback)
       override {
-    // TODO(melandory): Use ScopedVector instead of std::vector in arguments.
-    // ContentCredentialManagerDispatcher::OnGetPasswordStoreResults contains a
-    // memory leak because of this.
     EXPECT_FALSE(local_forms.empty() && federated_forms.empty());
     did_prompt_user_to_choose_ = true;
-    ScopedVector<autofill::PasswordForm> local_entries;
-    local_entries.assign(local_forms.begin(), local_forms.end());
-    ScopedVector<autofill::PasswordForm> federated_entries;
-    federated_entries.assign(federated_forms.begin(), federated_forms.end());
     password_manager::CredentialInfo info(
-        local_forms.empty() ? *federated_forms[0] : *local_entries[0],
+        local_forms.empty() ? *federated_forms[0] : *local_forms[0],
         local_forms.empty()
             ? password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED
             : password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);
     base::MessageLoop::current()->PostTask(FROM_HERE,
                                            base::Bind(callback, info));
     return true;
   }
 
   bool IsOffTheRecord() override { return is_off_the_record_; }
 
@@ skipping 419 matching lines @@
   const IPC::Message* message =
       process()->sink().GetFirstMessageMatching(kMsgID);
   ASSERT_TRUE(message);
   CredentialManagerMsg_SendCredential::Param param;
   CredentialManagerMsg_SendCredential::Read(message, &param);
   EXPECT_EQ(CredentialType::CREDENTIAL_TYPE_EMPTY, get<1>(param).type);
   EXPECT_FALSE(client_->did_prompt_user_to_choose());
 }
 
 }  // namespace password_manager