Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/password_manager/password_store_mac.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Second fix of the rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 const autofill::PasswordForm& form) override; 71 const autofill::PasswordForm& form) override;
72 password_manager::PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl( 72 password_manager::PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(
73 base::Time delete_begin, 73 base::Time delete_begin,
74 base::Time delete_end) override; 74 base::Time delete_end) override;
75 password_manager::PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl( 75 password_manager::PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
76 base::Time delete_begin, 76 base::Time delete_begin,
77 base::Time delete_end) override; 77 base::Time delete_end) override;
78 void GetLoginsImpl(const autofill::PasswordForm& form, 78 void GetLoginsImpl(const autofill::PasswordForm& form,
79 AuthorizationPromptPolicy prompt_policy, 79 AuthorizationPromptPolicy prompt_policy,
80 const ConsumerCallbackRunner& callback_runner) override; 80 const ConsumerCallbackRunner& callback_runner) override;
81 void GetAutofillableLoginsImpl(GetLoginsRequest* request) override; 81 void GetAutofillableLoginsImpl(
82 void GetBlacklistLoginsImpl(GetLoginsRequest* request) override; 82 scoped_ptr<PasswordStore::GetLoginsRequest> request) override;
83 void GetBlacklistLoginsImpl(
84 scoped_ptr<PasswordStore::GetLoginsRequest> request) override;
83 bool FillAutofillableLogins( 85 bool FillAutofillableLogins(
84 ScopedVector<autofill::PasswordForm>* forms) override; 86 ScopedVector<autofill::PasswordForm>* forms) override;
85 bool FillBlacklistLogins( 87 bool FillBlacklistLogins(
86 ScopedVector<autofill::PasswordForm>* forms) override; 88 ScopedVector<autofill::PasswordForm>* forms) override;
87 89
88 // Adds the given form to the Keychain if it's something we want to store 90 // Adds the given form to the Keychain if it's something we want to store
89 // there (i.e., not a blacklist entry). Returns true if the operation 91 // there (i.e., not a blacklist entry). Returns true if the operation
90 // succeeded (either we added successfully, or we didn't need to). 92 // succeeded (either we added successfully, or we didn't need to).
91 bool AddToKeychainIfNecessary(const autofill::PasswordForm& form); 93 bool AddToKeychainIfNecessary(const autofill::PasswordForm& form);
92 94
(...skipping 23 matching lines...) Expand all
116 // |login_metadata_db_| will be reset to NULL for the lifetime of |this|. 118 // |login_metadata_db_| will be reset to NULL for the lifetime of |this|.
117 scoped_ptr<password_manager::LoginDatabase> login_metadata_db_; 119 scoped_ptr<password_manager::LoginDatabase> login_metadata_db_;
118 120
119 // Thread that the synchronous methods are run on. 121 // Thread that the synchronous methods are run on.
120 scoped_ptr<base::Thread> thread_; 122 scoped_ptr<base::Thread> thread_;
121 123
122 DISALLOW_COPY_AND_ASSIGN(PasswordStoreMac); 124 DISALLOW_COPY_AND_ASSIGN(PasswordStoreMac);
123 }; 125 };
124 126
125 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_ 127 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698