Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Second fix of the rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "components/password_manager/content/browser/content_password_manager_d river_factory.h" 10 #include "components/password_manager/content/browser/content_password_manager_d river_factory.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 bool ShouldAskUserToSubmitURL(const GURL& url) override; 46 bool ShouldAskUserToSubmitURL(const GURL& url) override;
47 bool ShouldFilterAutofillResult(const autofill::PasswordForm& form) override; 47 bool ShouldFilterAutofillResult(const autofill::PasswordForm& form) override;
48 std::string GetSyncUsername() const override; 48 std::string GetSyncUsername() const override;
49 bool IsSyncAccountCredential(const std::string& username, 49 bool IsSyncAccountCredential(const std::string& username,
50 const std::string& origin) const override; 50 const std::string& origin) const override;
51 void AskUserAndMaybeReportURL(const GURL& url) const override; 51 void AskUserAndMaybeReportURL(const GURL& url) const override;
52 void AutofillResultsComputed() override; 52 void AutofillResultsComputed() override;
53 bool PromptUserToSavePassword( 53 bool PromptUserToSavePassword(
54 scoped_ptr<password_manager::PasswordFormManager> form_to_save) override; 54 scoped_ptr<password_manager::PasswordFormManager> form_to_save) override;
55 bool PromptUserToChooseCredentials( 55 bool PromptUserToChooseCredentials(
56 const std::vector<autofill::PasswordForm*>& local_forms, 56 ScopedVector<autofill::PasswordForm> local_forms,
57 const std::vector<autofill::PasswordForm*>& federated_forms, 57 ScopedVector<autofill::PasswordForm> federated_forms,
58 base::Callback<void(const password_manager::CredentialInfo&)> 58 base::Callback<void(const password_manager::CredentialInfo&)> callback)
59 callback) override; 59 override;
60 void AutomaticPasswordSave(scoped_ptr<password_manager::PasswordFormManager> 60 void AutomaticPasswordSave(scoped_ptr<password_manager::PasswordFormManager>
61 saved_form_manager) override; 61 saved_form_manager) override;
62 void PasswordWasAutofilled( 62 void PasswordWasAutofilled(
63 const autofill::PasswordFormMap& best_matches) const override; 63 const autofill::PasswordFormMap& best_matches) const override;
64 void PasswordAutofillWasBlocked( 64 void PasswordAutofillWasBlocked(
65 const autofill::PasswordFormMap& best_matches) const override; 65 const autofill::PasswordFormMap& best_matches) const override;
66 PrefService* GetPrefs() override; 66 PrefService* GetPrefs() override;
67 password_manager::PasswordStore* GetPasswordStore() override; 67 password_manager::PasswordStore* GetPasswordStore() override;
68 base::FieldTrial::Probability GetProbabilityForExperiment( 68 base::FieldTrial::Probability GetProbabilityForExperiment(
69 const std::string& experiment_name) override; 69 const std::string& experiment_name) override;
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 AutofillForSyncCredentialsState autofill_sync_state_; 169 AutofillForSyncCredentialsState autofill_sync_state_;
170 170
171 // If the sync credential was filtered during autofill. Used for statistics 171 // If the sync credential was filtered during autofill. Used for statistics
172 // reporting. 172 // reporting.
173 bool sync_credential_was_filtered_; 173 bool sync_credential_was_filtered_;
174 174
175 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 175 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
176 }; 176 };
177 177
178 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 178 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698