GetLoginsRequest: Use ScopedVector to express ownership of forms

components/password_manager/core/browser/test_password_store.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/test_password_store.h"
 
 #include "components/autofill/core/common/password_form.h"
 
 namespace password_manager {
 
@@ skipping 28 matching lines @@
 bool TestPasswordStore::FormsAreEquivalent(const autofill::PasswordForm& lhs,
                                            const autofill::PasswordForm& rhs) {
   return lhs.origin == rhs.origin &&
       lhs.username_element == rhs.username_element &&
       lhs.username_value == rhs.username_value &&
       lhs.password_element == rhs.password_element &&
       lhs.signon_realm == rhs.signon_realm;
 }
 
 void TestPasswordStore::GetAutofillableLoginsImpl(
-    PasswordStore::GetLoginsRequest* request) {
+    scoped_ptr<GetLoginsRequest> request) {
   for (auto& forms_for_realm : stored_passwords_) {

[vasilii, 2015/02/09 10:08:35]

const auto&

[vabr (Chromium), 2015/02/09 11:36:06]

Done.

     for (const autofill::PasswordForm& form : forms_for_realm.second)
       request->result()->push_back(new autofill::PasswordForm(form));
   }
-  ForwardLoginsResult(request);
+  ForwardLoginsResult(request.Pass());
 }
 
 PasswordStoreChangeList TestPasswordStore::AddLoginImpl(
     const autofill::PasswordForm& form) {
   PasswordStoreChangeList changes;
   stored_passwords_[form.signon_realm].push_back(form);
   changes.push_back(PasswordStoreChange(PasswordStoreChange::ADD, form));
   return changes;
 }
 
@@ skipping 35 matching lines @@
     const PasswordStore::ConsumerCallbackRunner& runner) {
   ScopedVector<autofill::PasswordForm> matched_forms;
   std::vector<autofill::PasswordForm> forms =
       stored_passwords_[form.signon_realm];
   for (const auto& stored_form : forms) {
     matched_forms.push_back(new autofill::PasswordForm(stored_form));
   }
   runner.Run(matched_forms.Pass());
 }
 
+void TestPasswordStore::ReportMetricsImpl(const std::string& sync_username,
+                                          bool custom_passphrase_sync_enabled) {
+}
+
 PasswordStoreChangeList TestPasswordStore::RemoveLoginsCreatedBetweenImpl(
     base::Time begin,
     base::Time end) {
   PasswordStoreChangeList changes;
   return changes;
 }
 
 PasswordStoreChangeList TestPasswordStore::RemoveLoginsSyncedBetweenImpl(
     base::Time begin,
     base::Time end) {
   PasswordStoreChangeList changes;
   return changes;
 }
 
+void TestPasswordStore::GetBlacklistLoginsImpl(
+    scoped_ptr<GetLoginsRequest> request) {
+}
+
 bool TestPasswordStore::FillAutofillableLogins(
     ScopedVector<autofill::PasswordForm>* forms) {
   return true;
 }
 
 bool TestPasswordStore::FillBlacklistLogins(
     ScopedVector<autofill::PasswordForm>* forms) {
   return true;
 }
 
 }  // namespace password_manager