GetLoginsRequest: Use ScopedVector to express ownership of forms

components/password_manager/core/browser/password_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_manager.h"
 
 #include <string>
 #include <vector>
 
 #include "base/message_loop/message_loop.h"
@@ skipping 49 matching lines @@
   }
 };
 
 class MockPasswordManagerDriver : public StubPasswordManagerDriver {
  public:
   MOCK_METHOD1(FillPasswordForm, void(const autofill::PasswordFormFillData&));
   MOCK_METHOD0(GetPasswordManager, PasswordManager*());
   MOCK_METHOD0(GetPasswordAutofillManager, PasswordAutofillManager*());
 };
 
-ACTION_P(InvokeConsumer, forms) { arg0->OnGetPasswordStoreResults(forms); }
+ACTION_P(InvokeConsumer, forms) {
+  arg0->OnGetPasswordStoreResults(forms->Pass());
+}
 
 ACTION_P(SaveToScopedPtr, scoped) { scoped->reset(arg0); }
 
 class TestPasswordManager : public PasswordManager {
  public:
   explicit TestPasswordManager(PasswordManagerClient* client)
       : PasswordManager(client) {}
   ~TestPasswordManager() override {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestPasswordManager);
 };
 
 }  // namespace
 
 class PasswordManagerTest : public testing::Test {
  protected:
   void SetUp() override {
     prefs_.registry()->RegisterBooleanPref(prefs::kPasswordManagerSavingEnabled,
                                            true);
 
     store_ = new MockPasswordStore;
-    EXPECT_CALL(*store_.get(), ReportMetrics(_, _)).Times(AnyNumber());
+    EXPECT_CALL(*store_, ReportMetrics(_, _)).Times(AnyNumber());
     CHECK(store_->Init(syncer::SyncableService::StartSyncFlare()));
 
     EXPECT_CALL(client_, IsPasswordManagerEnabledForCurrentPage())
         .WillRepeatedly(Return(true));
     EXPECT_CALL(client_, IsSyncAccountCredential(_, _))
         .WillRepeatedly(Return(false));
     EXPECT_CALL(client_, GetPasswordStore())
         .WillRepeatedly(Return(store_.get()));
     EXPECT_CALL(client_, GetPrefs()).WillRepeatedly(Return(&prefs_));
     EXPECT_CALL(client_, GetDriver()).WillRepeatedly(Return(&driver_));
@@ skipping 131 matching lines @@
          form.action == arg.action &&
          form.username_element == arg.username_element &&
          form.password_element == arg.password_element &&
          form.new_password_element == arg.new_password_element &&
          form.password_autocomplete_set == arg.password_autocomplete_set &&
          form.submit_element == arg.submit_element;
 }
 
 TEST_F(PasswordManagerTest, FormSubmitEmptyStore) {
   // Test that observing a newly submitted form shows the save password bar.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));

[vasilii, 2015/02/05 19:23:27]

Do you really need Return() here and below?

[vabr (Chromium), 2015/02/06 14:16:05]

No. :) Done.

   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   // The initial load.
   manager()->OnPasswordFormsParsed(&driver_, observed);
   // The initial layout.
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 
   // And the form submit contract is to call ProvisionallySavePassword.
   manager()->ProvisionallySavePassword(form);
 
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
 
   // Now the password manager waits for the navigation to complete.
   observed.clear();
   // The post-navigation load.
   manager()->OnPasswordFormsParsed(&driver_, observed);
   // The post-navigation layout.
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 
   ASSERT_TRUE(form_to_save.get());
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form)));
 
   // Simulate saving the form, as if the info bar was accepted.
   form_to_save->Save();
 }
 
 TEST_F(PasswordManagerTest, FormSubmitWithOnlyNewPasswordField) {
   // This test is the same as FormSubmitEmptyStore, except that it simulates the
   // user entering credentials into a sign-up form that only has a new password
   // field.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
@@ skipping 12 matching lines @@
 
   // Now the password manager waits for the navigation to complete.
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_, observed);
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 
   ASSERT_TRUE(form_to_save.get());
 
   // Simulate saving the form, as if the info bar was accepted.
   PasswordForm saved_form;
-  EXPECT_CALL(*store_.get(), AddLogin(_))
-      .WillOnce(testing::SaveArg<0>(&saved_form));
+  EXPECT_CALL(*store_, AddLogin(_)).WillOnce(testing::SaveArg<0>(&saved_form));
   form_to_save->Save();
 
   // The value of the new password field should have been promoted to, and saved
   // to the password store as the current password, and no password element name
   // should have been saved.
   PasswordForm expected_form(form);
   expected_form.password_value.swap(expected_form.new_password_value);
   expected_form.new_password_element.clear();
   EXPECT_THAT(saved_form, FormMatches(expected_form));
   EXPECT_EQ(expected_form.password_value, saved_form.password_value);
   EXPECT_EQ(expected_form.new_password_value, saved_form.new_password_value);
 }
 
 TEST_F(PasswordManagerTest, GeneratedPasswordFormSubmitEmptyStore) {
   // This test is the same as FormSubmitEmptyStore, except that it simulates the
   // user generating the password through the browser.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   // The initial load.
   manager()->OnPasswordFormsParsed(&driver_, observed);
   // The initial layout.
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 
   // Simulate the user generating the password and submitting the form.
   manager()->SetFormHasGeneratedPassword(&driver_, form);
   manager()->ProvisionallySavePassword(form);
 
   // The user should not be presented with an infobar as they have already given
   // consent by using the generated password. The form should be saved once
   // navigation occurs. The client will be informed that automatic saving has
   // occured.
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form)));
   scoped_ptr<PasswordFormManager> saved_form_manager;
   EXPECT_CALL(client_, AutomaticPasswordSavePtr(_))
       .Times(Exactly(1))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&saved_form_manager)));
 
   // Now the password manager waits for the navigation to complete.
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 }
 
 TEST_F(PasswordManagerTest, FormSubmitNoGoodMatch) {
   // Same as above, except with an existing form for the same signon realm,
   // but different origin.  Detailed cases like this are covered by
   // PasswordFormManagerTest.
-  std::vector<PasswordForm*> result;
-  PasswordForm* existing_different = new PasswordForm(MakeSimpleForm());
+  ScopedVector<PasswordForm> result;
+  scoped_ptr<PasswordForm> existing_different(
+      new PasswordForm(MakeSimpleForm()));
   existing_different->username_value = ASCIIToUTF16("google2");
-  result.push_back(existing_different);
+  result.push_back(existing_different.release());
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(2);
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
 
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
   manager()->ProvisionallySavePassword(form);
 
   // We still expect an add, since we didn't have a good match.
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
 
   // Now the password manager waits for the navigation to complete.
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 
   ASSERT_TRUE(form_to_save.get());
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form)));
 
   // Simulate saving the form.
   form_to_save->Save();
 }
 
 TEST_F(PasswordManagerTest, FormSeenThenLeftPage) {
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   // No message from the renderer that a password was submitted. No
   // expected calls.
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_)).Times(0);
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 }
 
 TEST_F(PasswordManagerTest, FormSubmitAfterNavigateInPage) {
   // Test that navigating in the page does not prevent us from showing the save
   // password infobar.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   // Simulate submitting the password.
   OnPasswordFormSubmitted(form);
 
   // Now the password manager waits for the navigation to complete.
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
 
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 
   ASSERT_FALSE(NULL == form_to_save.get());
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form)));
 
   // Simulate saving the form, as if the info bar was accepted.
   form_to_save->Save();
 }
 
 // This test verifies a fix for http://crbug.com/236673
 TEST_F(PasswordManagerTest, FormSubmitWithFormOnPreviousPage) {
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   PasswordForm first_form(MakeSimpleForm());
   first_form.origin = GURL("http://www.nytimes.com/");
   first_form.action = GURL("https://myaccount.nytimes.com/auth/login");
   first_form.signon_realm = "http://www.nytimes.com/";
   PasswordForm second_form(MakeSimpleForm());
   second_form.origin = GURL("https://myaccount.nytimes.com/auth/login");
   second_form.action = GURL("https://myaccount.nytimes.com/auth/login");
   second_form.signon_realm = "https://myaccount.nytimes.com/";
 
   // Pretend that the form is hidden on the first page.
@@ skipping 18 matching lines @@
   // Navigation after form submit.
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_, observed);
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 
   // Make sure that the saved form matches the second form, not the first.
   ASSERT_TRUE(form_to_save.get());
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(second_form)));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(second_form)));
 
   // Simulate saving the form, as if the info bar was accepted.
   form_to_save->Save();
 }
 
 TEST_F(PasswordManagerTest, FormSubmitFailedLogin) {
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   manager()->ProvisionallySavePassword(form);
 
   // The form reappears, and is visible in the layout:
   // No expected calls to the PasswordStore...
   manager()->OnPasswordFormsParsed(&driver_, observed);
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 }
 
 TEST_F(PasswordManagerTest, FormSubmitInvisibleLogin) {
   // Tests fix of issue 28911: if the login form reappears on the subsequent
   // page, but is invisible, it shouldn't count as a failed login.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   manager()->ProvisionallySavePassword(form);
 
   // Expect info bar to appear:
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
 
   // The form reappears, but is not visible in the layout:
   manager()->OnPasswordFormsParsed(&driver_, observed);
   observed.clear();
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 
   ASSERT_TRUE(form_to_save.get());
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form)));
 
   // Simulate saving the form.
   form_to_save->Save();
 }
 
 TEST_F(PasswordManagerTest, InitiallyInvisibleForm) {
   // Make sure an invisible login form still gets autofilled.
-  std::vector<PasswordForm*> result;
-  PasswordForm* existing = new PasswordForm(MakeSimpleForm());
-  result.push_back(existing);
+  ScopedVector<PasswordForm> result;
+  result.push_back(new PasswordForm(MakeSimpleForm()));
   EXPECT_CALL(driver_, FillPasswordForm(_));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   observed.clear();
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 }
 
 TEST_F(PasswordManagerTest, SavingDependsOnManagerEnabledPreference) {
   // Test that saving passwords depends on the password manager enabled
   // preference.
   prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,
                      new base::FundamentalValue(true));
   EXPECT_TRUE(manager()->IsSavingEnabledForCurrentPage());
   prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,
                      new base::FundamentalValue(false));
   EXPECT_FALSE(manager()->IsSavingEnabledForCurrentPage());
 }
 
 TEST_F(PasswordManagerTest, FillPasswordsOnDisabledManager) {
   // Test fix for issue 158296: Passwords must be filled even if the password
   // manager is disabled.
-  std::vector<PasswordForm*> result;
-  PasswordForm* existing = new PasswordForm(MakeSimpleForm());
-  result.push_back(existing);
+  ScopedVector<PasswordForm> result;
+  result.push_back(new PasswordForm(MakeSimpleForm()));
   prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,
                      new base::FundamentalValue(false));
   EXPECT_CALL(driver_, FillPasswordForm(_));
-  EXPECT_CALL(*store_.get(),
+  EXPECT_CALL(*store_,
               GetLogins(_, testing::Eq(PasswordStore::DISALLOW_PROMPT), _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);
 }
 
 TEST_F(PasswordManagerTest, FormSavedWithAutocompleteOff) {
   // Test password form with non-generated password will be saved even if
   // autocomplete=off.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   form.password_autocomplete_set = false;
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   // And the form submit contract is to call ProvisionallySavePassword.
   manager()->ProvisionallySavePassword(form);
 
   // Password form should be saved.
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .Times(Exactly(1))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form))).Times(Exactly(0));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form))).Times(Exactly(0));
 
   // Now the password manager waits for the navigation to complete.
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 
   ASSERT_TRUE(form_to_save.get());
 }
 
 TEST_F(PasswordManagerTest, GeneratedPasswordFormSavedAutocompleteOff) {
   // Test password form with generated password will still be saved if
   // autocomplete=off.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   form.password_autocomplete_set = false;
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   // Simulate the user generating the password and submitting the form.
   manager()->SetFormHasGeneratedPassword(&driver_, form);
   manager()->ProvisionallySavePassword(form);
 
   // The user should not be presented with an infobar as they have already given
   // consent by using the generated password. The form should be saved once
   // navigation occurs. The client will be informed that automatic saving has
   // occured.
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form)));
   scoped_ptr<PasswordFormManager> saved_form_manager;
   EXPECT_CALL(client_, AutomaticPasswordSavePtr(_))
       .Times(Exactly(1))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&saved_form_manager)));
 
   // Now the password manager waits for the navigation to complete.
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 }
 
 TEST_F(PasswordManagerTest, SubmissionCallbackTest) {
   manager()->AddSubmissionCallback(SubmissionCallback());
   PasswordForm form = MakeSimpleForm();
   OnPasswordFormSubmitted(form);
   EXPECT_TRUE(FormsAreEqual(form, submitted_form_));
 }
 
 TEST_F(PasswordManagerTest, PasswordFormReappearance) {
   // Test the heuristic to know if a password form reappears.
   // We assume that if we send our credentials and there
   // is at least one visible password form in the next page that
   // means that our previous login attempt failed.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(0);
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm login_form(MakeTwitterLoginForm());
   observed.push_back(login_form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   manager()->ProvisionallySavePassword(login_form);
 
   PasswordForm failed_login_form(MakeTwitterFailedLoginForm());
@@ skipping 16 matching lines @@
   // attempt to autofill forms found on a website.
   EXPECT_CALL(client_, DidLastPageLoadEncounterSSLErrors())
       .WillRepeatedly(Return(true));
 
   // Let us pretend some forms were found on a website.
   std::vector<PasswordForm> forms;
   forms.push_back(MakeSimpleForm());
 
   // Feed those forms to |manager()| and check that it does not try to find
   // matching saved credentials for the forms.
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _)).Times(Exactly(0));
+  EXPECT_CALL(*store_, GetLogins(_, _, _)).Times(Exactly(0));
   manager()->OnPasswordFormsParsed(&driver_, forms);
 }
 
 TEST_F(PasswordManagerTest, SavingDisabledIfManagerDisabled) {
   EXPECT_CALL(client_, IsPasswordManagerEnabledForCurrentPage())
       .WillRepeatedly(Return(false));
   EXPECT_FALSE(manager()->IsSavingEnabledForCurrentPage());
 }
 
 TEST_F(PasswordManagerTest, AutofillingDisabledIfManagerDisabled) {
   EXPECT_CALL(client_, IsPasswordManagerEnabledForCurrentPage())
       .WillRepeatedly(Return(false));
 
   // Let us pretend some forms were found on a website.
   std::vector<PasswordForm> forms;
   forms.push_back(MakeSimpleForm());
 
   // Feed those forms to |manager()| and check that it does not try to find
   // matching saved credentials for the forms.
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _)).Times(Exactly(0));
+  EXPECT_CALL(*store_, GetLogins(_, _, _)).Times(Exactly(0));
   manager()->OnPasswordFormsParsed(&driver_, forms);
 }
 
 TEST_F(PasswordManagerTest, SyncCredentialsNotSaved) {
   EXPECT_CALL(client_, IsSyncAccountCredential(_, _))
       .WillRepeatedly(Return(true));
 
   // Simulate loading a simple form with no existing stored password.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   form.password_autocomplete_set = false;
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   // User should not be prompted and password should not be saved.
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form))).Times(Exactly(0));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form))).Times(Exactly(0));
 
   // Submit form and finish navigation.
   manager()->ProvisionallySavePassword(form);
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_, observed);
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 }
 
 // On failed login attempts, the retry-form can have action scheme changed from
 // HTTP to HTTPS (see http://crbug.com/400769). Check that such retry-form is
 // considered equal to the original login form, and the attempt recognised as a
 // failure.
 TEST_F(PasswordManagerTest,
        SeeingFormActionWithOnlyHttpHttpsChangeIsLoginFailure) {
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillRepeatedly(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
 
   PasswordForm first_form(MakeSimpleForm());
   first_form.origin = GURL("http://www.xda-developers.com/");
   first_form.action = GURL("http://forum.xda-developers.com/login.php");
 
   // |second_form|'s action differs only with it's scheme i.e. *https://*.
   PasswordForm second_form(first_form);
   second_form.action = GURL("https://forum.xda-developers.com/login.php");
 
   std::vector<PasswordForm> observed;
@@ skipping 38 matching lines @@
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 }
 
 TEST_F(PasswordManagerTest, FormSubmitWithOnlyPassowrdField) {
   // Test to verify that on submitting the HTML password form without having
   // username input filed shows password save promt and saves the password to
   // store.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
   std::vector<PasswordForm> observed;
 
   // Loads passsword form without username input field.
   PasswordForm form(MakeSimpleFormWithOnlyPasswordField());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);  // The initial load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The initial layout.
 
   // And the form submit contract is to call ProvisionallySavePassword.
   manager()->ProvisionallySavePassword(form);
 
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
 
   // Now the password manager waits for the navigation to complete.
   observed.clear();
   manager()->OnPasswordFormsParsed(&driver_,
                                    observed);  // The post-navigation load.
   manager()->OnPasswordFormsRendered(&driver_, observed,
                                      true);  // The post-navigation layout.
 
   ASSERT_TRUE(form_to_save.get());
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
+  EXPECT_CALL(*store_, AddLogin(FormMatches(form)));
 
   // Simulate saving the form, as if the info bar was accepted.
   form_to_save->Save();
 }
 
 TEST_F(PasswordManagerTest, FillPasswordOnManyFrames) {
   // If one password form appears in more frames, it should be filled in all of
   // them.
   PasswordForm form(MakeSimpleForm());  // The observed and saved form.
 
   // "Save" the form.
-  std::vector<PasswordForm*> result;
-  result.push_back(new PasswordForm(form));  // Calee owns the form.
-  EXPECT_CALL(*store_.get(),
+  ScopedVector<PasswordForm> result;
+  result.push_back(new PasswordForm(form));
+  EXPECT_CALL(*store_,
               GetLogins(_, testing::Eq(PasswordStore::DISALLOW_PROMPT), _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));
 
   // The form will be seen the first time.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(1);
   std::vector<PasswordForm> observed;
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);
 
   // Now the form will be seen the second time, in a different frame. The driver
   // for that frame should be told to fill it, but the store should not be asked
   // for it again.
   MockPasswordManagerDriver driver_b;
   EXPECT_CALL(driver_b, FillPasswordForm(_)).Times(1);
   manager()->OnPasswordFormsParsed(&driver_b, observed);
 }
 
 TEST_F(PasswordManagerTest, InPageNavigation) {
   // Test that observing a newly submitted form shows the save password bar on
   // call in page navigation.
-  std::vector<PasswordForm*> result;  // Empty password store.
+  ScopedVector<PasswordForm> result;  // Empty password store.
   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
-      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  EXPECT_CALL(*store_, GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(&result)), Return()));

[vasilii, 2015/02/05 19:23:27]

The file is full of these calls. It seems that it's not the condition we want to
test. I'd move this to a test initialiser as
ON_CALL(*store_, GetLogins(_, _,
_)).WillByDefault(WithArg<2>(InvokeEmptyConsumer));

[vabr (Chromium), 2015/02/06 14:16:05]

Great idea!
Done.

[vasilii, 2015/02/09 10:08:34]

I don't see it's done.

[vabr (Chromium), 2015/02/09 11:36:06]

Sorry, I focussed on adding the empty consumer action so much that I forgot the
other part of your comment. Remedied now.

   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   // The initial load.
   manager()->OnPasswordFormsParsed(&driver_, observed);
   // The initial layout.
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 
   // And the form submit contract is to call ProvisionallySavePassword.
   manager()->ProvisionallySavePassword(form);
 
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
 
   manager()->OnInPageNavigation(&driver_, form);
 }
 
 }  // namespace password_manager