GetLoginsRequest: Use ScopedVector to express ownership of forms

chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/sync/test/integration/passwords_helper.h"
 #include "chrome/browser/sync/test/integration/performance/sync_timing_helper.h"
 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
 #include "components/password_manager/core/browser/password_store.h"
 
 using passwords_helper::AddLogin;
 using passwords_helper::CreateTestPasswordForm;
-using passwords_helper::GetLogins;
 using passwords_helper::GetPasswordCount;
 using passwords_helper::GetPasswordStore;
 using passwords_helper::UpdateLogin;
 
 static const int kNumPasswords = 150;
 
 class PasswordsSyncPerfTest : public SyncTest {
  public:
   PasswordsSyncPerfTest() : SyncTest(TWO_CLIENT), password_number_(0) {}
 
@@ skipping 17 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(PasswordsSyncPerfTest);
 };
 
 void PasswordsSyncPerfTest::AddLogins(int profile, int num_logins) {
   for (int i = 0; i < num_logins; ++i) {
     AddLogin(GetPasswordStore(profile), NextLogin());
   }
 }
 
 void PasswordsSyncPerfTest::UpdateLogins(int profile) {
-  std::vector<autofill::PasswordForm> logins;
-  GetLogins(GetPasswordStore(profile), logins);
-  for (std::vector<autofill::PasswordForm>::iterator it = logins.begin();
-       it != logins.end(); ++it) {
-    (*it).password_value = base::ASCIIToUTF16(NextPassword());
-    UpdateLogin(GetPasswordStore(profile), (*it));
+  ScopedVector<autofill::PasswordForm> logins =
+      passwords_helper::GetLogins(GetPasswordStore(profile));
+  for (autofill::PasswordForm* login : logins) {
+    login->password_value = base::ASCIIToUTF16(NextPassword());
+    UpdateLogin(GetPasswordStore(profile), *login);
   }
 }
 
 void PasswordsSyncPerfTest::RemoveLogins(int profile) {
   passwords_helper::RemoveLogins(GetPasswordStore(profile));
 }
 
 autofill::PasswordForm PasswordsSyncPerfTest::NextLogin() {
   return CreateTestPasswordForm(password_number_++);
 }
@@ skipping 23 matching lines @@
   dt = SyncTimingHelper::TimeUntilQuiescence(clients());
   ASSERT_EQ(kNumPasswords, GetPasswordCount(1));
   SyncTimingHelper::PrintResult("passwords", "update_passwords", dt);
 
   // TCM ID - 7557852
   RemoveLogins(0);
   dt = SyncTimingHelper::TimeUntilQuiescence(clients());
   ASSERT_EQ(0, GetPasswordCount(1));
   SyncTimingHelper::PrintResult("passwords", "delete_passwords", dt);
 }