GetLoginsRequest: Use ScopedVector to express ownership of forms

chrome/browser/ui/passwords/password_manager_presenter.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/password_manager_presenter.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/prefs/pref_service.h"
@@ skipping 193 matching lines @@
 void PasswordManagerPresenter::PasswordListPopulater::Populate() {
   PasswordStore* store = page_->GetPasswordStore();
   if (store != NULL) {
     cancelable_task_tracker()->TryCancelAll();
     store->GetAutofillableLogins(this);
   } else {
     LOG(ERROR) << "No password store! Cannot display passwords.";
   }
 }
 
-void PasswordManagerPresenter::PasswordListPopulater::OnGetPasswordStoreResults(
-    const std::vector<autofill::PasswordForm*>& results) {
-  page_->password_list_.clear();
-  page_->password_list_.insert(page_->password_list_.end(),
-                               results.begin(), results.end());
+void PasswordManagerPresenter::PasswordListPopulater::
+    OnGetPasswordStoreResults() {
+  page_->password_list_.swap(*results());
   page_->SetPasswordList();
 }
 
 PasswordManagerPresenter::PasswordExceptionListPopulater::
     PasswordExceptionListPopulater(PasswordManagerPresenter* page)
         : ListPopulater(page) {
 }
 
 void PasswordManagerPresenter::PasswordExceptionListPopulater::Populate() {
   PasswordStore* store = page_->GetPasswordStore();
   if (store != NULL) {
     cancelable_task_tracker()->TryCancelAll();
     store->GetBlacklistLogins(this);
   } else {
     LOG(ERROR) << "No password store! Cannot display exceptions.";
   }
 }
 
 void PasswordManagerPresenter::PasswordExceptionListPopulater::
-    OnGetPasswordStoreResults(
-        const std::vector<autofill::PasswordForm*>& results) {
-  page_->password_exception_list_.clear();
-  page_->password_exception_list_.insert(page_->password_exception_list_.end(),
-                                         results.begin(), results.end());
+    OnGetPasswordStoreResults() {
+  page_->password_exception_list_.swap(*results());
   page_->SetPasswordExceptionList();
 }