Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 866973004: Disable Mojo on RenderThreadImplBrowserTest on Android (Closed)

Created:
5 years, 11 months ago by Hajime Morrita
Modified:
5 years, 11 months ago
Reviewers:
Jay Civelli, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Mojo on RenderThreadImplBrowserTest on Android It hasn't worked from the beginning and it blocks ChannelMojo from being enabled. BUG=451221 R=jcivelli@chromium.org, sky@chromium.org Committed: https://crrev.com/b5a99f2c1652471236c5d07403faa42bf53420df Cr-Commit-Position: refs/heads/master@{#312875}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 1 chunk +12 lines, -1 line 1 comment Download

Messages

Total messages: 8 (1 generated)
Hajime Morrita
5 years, 11 months ago (2015-01-22 23:34:19 UTC) #1
sky
LGTM assuming there is no other way to detect this. https://codereview.chromium.org/866973004/diff/1/content/test/render_thread_impl_browser_test_ipc_helper.cc File content/test/render_thread_impl_browser_test_ipc_helper.cc (right): https://codereview.chromium.org/866973004/diff/1/content/test/render_thread_impl_browser_test_ipc_helper.cc#newcode32 ...
5 years, 11 months ago (2015-01-23 00:43:49 UTC) #2
Hajime Morrita
On 2015/01/23 00:43:49, sky wrote: > LGTM assuming there is no other way to detect ...
5 years, 11 months ago (2015-01-23 17:53:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866973004/1
5 years, 11 months ago (2015-01-23 17:54:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 18:09:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b5a99f2c1652471236c5d07403faa42bf53420df Cr-Commit-Position: refs/heads/master@{#312875}
5 years, 11 months ago (2015-01-23 18:10:18 UTC) #7
Hajime Morrita
5 years, 11 months ago (2015-01-24 01:31:52 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/873913002/ by morrita@chromium.org.

The reason for reverting is: This doesn't work in some tests..

Powered by Google App Engine
This is Rietveld 408576698