Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 866893004: Gallery: Remove position: absolute; line for redo button. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Remove position: absolute; line for redo button. The line is specified for the hidden redu button does not affect layout of other buttons, but it removes the button from the layout even if the button is visible, and it causes overlapping of the buttons. Actually we can remove the line because hidden items are specified display: none; in Gallery. BUG=450186 TEST=None Committed: https://crrev.com/b170090d45fe82f30bdd7953862c3c6168c94f03 Cr-Commit-Position: refs/heads/master@{#313661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/file_manager/gallery/css/gallery.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hirono
PTAL? Thansk!
5 years, 10 months ago (2015-01-29 03:23:50 UTC) #2
fukino
lgtm
5 years, 10 months ago (2015-01-29 03:26:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866893004/1
5 years, 10 months ago (2015-01-29 03:33:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 03:52:51 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 03:53:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b170090d45fe82f30bdd7953862c3c6168c94f03
Cr-Commit-Position: refs/heads/master@{#313661}

Powered by Google App Engine
This is Rietveld 408576698