Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 866883003: cc: Remove TilingSetRasterQueue virtual base. (Closed)

Created:
5 years, 11 months ago by vmpstr
Modified:
5 years, 11 months ago
Reviewers:
danakj, reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove TilingSetRasterQueue virtual base. This patch removes the virtual base class for the tiling set raster queues, since the calling code (raster tile priority queues) knows exactly what type it's using. R=reveman, danakj Committed: https://crrev.com/62c72c35125f22c9b80331ba39c309cea937fffb Cr-Commit-Position: refs/heads/master@{#312974}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : gyp/gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -82 lines) Patch
M cc/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 6 chunks +21 lines, -18 lines 0 comments Download
M cc/resources/raster_tile_priority_queue_all.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M cc/resources/raster_tile_priority_queue_all.cc View 1 7 chunks +8 lines, -9 lines 0 comments Download
M cc/resources/raster_tile_priority_queue_required.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/raster_tile_priority_queue_required.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D cc/resources/tiling_set_raster_queue.h View 1 chunk +0 lines, -25 lines 0 comments Download
M cc/resources/tiling_set_raster_queue_all.h View 1 chunk +6 lines, -8 lines 0 comments Download
M cc/resources/tiling_set_raster_queue_required.h View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
vmpstr
Please take a look. This depends on https://codereview.chromium.org/863013004/
5 years, 11 months ago (2015-01-22 20:03:04 UTC) #1
vmpstr
I've rebased this, since the required patch landed.
5 years, 11 months ago (2015-01-23 21:20:29 UTC) #3
danakj
https://codereview.chromium.org/866883003/diff/40001/cc/resources/tiling_set_raster_queue.h File cc/resources/tiling_set_raster_queue.h (left): https://codereview.chromium.org/866883003/diff/40001/cc/resources/tiling_set_raster_queue.h#oldcode1 cc/resources/tiling_set_raster_queue.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 11 months ago (2015-01-23 22:20:30 UTC) #4
vmpstr
PTAL https://codereview.chromium.org/866883003/diff/40001/cc/resources/tiling_set_raster_queue.h File cc/resources/tiling_set_raster_queue.h (left): https://codereview.chromium.org/866883003/diff/40001/cc/resources/tiling_set_raster_queue.h#oldcode1 cc/resources/tiling_set_raster_queue.h:1: // Copyright 2014 The Chromium Authors. All rights ...
5 years, 11 months ago (2015-01-23 23:16:11 UTC) #5
danakj
LGTM
5 years, 11 months ago (2015-01-23 23:17:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866883003/60001
5 years, 11 months ago (2015-01-23 23:21:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866883003/60001
5 years, 11 months ago (2015-01-23 23:29:25 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 11 months ago (2015-01-24 00:24:36 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 00:25:33 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/62c72c35125f22c9b80331ba39c309cea937fffb
Cr-Commit-Position: refs/heads/master@{#312974}

Powered by Google App Engine
This is Rietveld 408576698