Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: chromecast/chromecast.gyp

Issue 866843004: Replace CAST_BUILD_REVISION with <major>.<minor>.<incremental>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle the cast when cast_build_release is not available. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/common/version.h.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/chromecast.gyp
diff --git a/chromecast/chromecast.gyp b/chromecast/chromecast.gyp
index c9335f0093c20bf3130278d0200fc6b7c3b74f61..ff324ce3f8eed3d22e15e972eba6d4ec52de9ebe 100644
--- a/chromecast/chromecast.gyp
+++ b/chromecast/chromecast.gyp
@@ -6,6 +6,7 @@
'variables': {
'android_support_v13_target%':
'../third_party/android_tools/android_tools.gyp:android_support_v13_javalib',
+ 'cast_build_release': 'internal/build/cast_build_release',
'chromium_code': 1,
'chromecast_branding%': 'Chromium',
'disable_display%': 0,
@@ -260,8 +261,12 @@
'python',
'<(version_py_path)',
'-e', 'VERSION_FULL="<(version_full)"',
- # Revision is taken from buildbot if available; otherwise, a dev string is used.
- '-e', 'CAST_BUILD_REVISION="<!(echo ${CAST_BUILD_REVISION:="eng.${USER}.<!(date +%Y%m%d.%H%M%S)"})"',
+ # CAST_BUILD_INCREMENTAL is taken from buildbot if available;
+ # otherwise, a dev string is used.
+ '-e', 'CAST_BUILD_INCREMENTAL="<!(echo ${CAST_BUILD_INCREMENTAL:="<!(date +%Y%m%d.%H%M%S)"})"',
+ # CAST_BUILD_RELEASE is taken from cast_build_release file if exist;
+ # otherwize, a dev string is used.
gunsch 2015/01/23 17:33:30 nit: otherwize --> otherwise
byungchul 2015/01/23 17:51:27 Done.
+ '-e', 'CAST_BUILD_RELEASE="<!(if [[ -f <(cast_build_release) ]]; then cat <(cast_build_release); else echo eng.${USER}; fi)"',
gunsch 2015/01/23 17:33:30 Do we know for sure that gyp uses bash shells to r
byungchul 2015/01/23 17:51:27 Done.
'-e', 'CAST_IS_DEBUG_BUILD=1 if "<(CONFIGURATION_NAME)" == "Debug" else 0',
'common/version.h.in',
'<@(_outputs)',
« no previous file with comments | « no previous file | chromecast/common/version.h.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698