Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6432)

Unified Diff: chromecast/chromecast.gyp

Issue 866843004: Replace CAST_BUILD_REVISION with <major>.<minor>.<incremental>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/common/version.h.in » ('j') | chromecast/common/version.h.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/chromecast.gyp
diff --git a/chromecast/chromecast.gyp b/chromecast/chromecast.gyp
index c9335f0093c20bf3130278d0200fc6b7c3b74f61..4d51e68a8424e3c9790c60a66ee42d60766e4737 100644
--- a/chromecast/chromecast.gyp
+++ b/chromecast/chromecast.gyp
@@ -260,8 +260,10 @@
'python',
'<(version_py_path)',
'-e', 'VERSION_FULL="<(version_full)"',
- # Revision is taken from buildbot if available; otherwise, a dev string is used.
- '-e', 'CAST_BUILD_REVISION="<!(echo ${CAST_BUILD_REVISION:="eng.${USER}.<!(date +%Y%m%d.%H%M%S)"})"',
+ # Cast build numbers are taken from buildbot if available;
+ # otherwise, dev strings are used.
+ '-e', 'CAST_BUILD_INCREMENTAL="<!(echo ${CAST_BUILD_INCREMENTAL:="<!(date +%Y%m%d.%H%M%S)"})"',
+ '-e', 'CAST_BUILD_RELEASE="<!(echo ${CAST_BUILD_RELEASE:="eng.${USER}"})"',
gunsch 2015/01/22 17:42:05 where does CAST_BUILD_RELEASE come from? I don't s
byungchul 2015/01/22 17:47:54 This will be set by chromecast.mk based on PLATFOR
gunsch 2015/01/22 19:46:20 Discussed offline about the issues with this appro
byungchul 2015/01/22 19:46:33 Changed to read from cast_build_release file which
'-e', 'CAST_IS_DEBUG_BUILD=1 if "<(CONFIGURATION_NAME)" == "Debug" else 0',
'common/version.h.in',
'<@(_outputs)',
« no previous file with comments | « no previous file | chromecast/common/version.h.in » ('j') | chromecast/common/version.h.in » ('J')

Powered by Google App Engine
This is Rietveld 408576698