Replace CAST_BUILD_REVISION with <major>.<minor>.<incremental>.

chromecast/chromecast.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'android_support_v13_target%':
         '../third_party/android_tools/android_tools.gyp:android_support_v13_javalib',
     'chromium_code': 1,
     'chromecast_branding%': 'Chromium',
@@ skipping 242 matching lines @@
             '<(version_path)',
             'common/version.h.in',
           ],
           'outputs': [
             '<(SHARED_INTERMEDIATE_DIR)/chromecast/common/version.h',
           ],
           'action': [
             'python',
             '<(version_py_path)',
             '-e', 'VERSION_FULL="<(version_full)"',
-            # Revision is taken from buildbot if available; otherwise, a dev string is used.
-            '-e', 'CAST_BUILD_REVISION="<!(echo ${CAST_BUILD_REVISION:="eng.${USER}.<!(date +%Y%m%d.%H%M%S)"})"',
+            # Cast build numbers are taken from buildbot if available;
+            # otherwise, dev strings are used.
+            '-e', 'CAST_BUILD_INCREMENTAL="<!(echo ${CAST_BUILD_INCREMENTAL:="<!(date +%Y%m%d.%H%M%S)"})"',
+            '-e', 'CAST_BUILD_RELEASE="<!(echo ${CAST_BUILD_RELEASE:="eng.${USER}"})"',

[gunsch, 2015/01/22 17:42:05]

where does CAST_BUILD_RELEASE come from? I don't see this on the builders.

[byungchul, 2015/01/22 17:47:54]

This will be set by chromecast.mk based on PLATFORM_VERSION in
build/core/version_defaults.mk. I didn't want to describe it here because
version_defaults.mk are not available.

[gunsch, 2015/01/22 19:46:20]

Discussed offline about the issues with this approach.

Let's figure out how to set CAST_BUILD_RELEASE consistently in all of our
downstream builds first.

[byungchul, 2015/01/22 19:46:33]

Changed to read from cast_build_release file which will be set by build env
script.

             '-e', 'CAST_IS_DEBUG_BUILD=1 if "<(CONFIGURATION_NAME)" == "Debug" else 0',
             'common/version.h.in',
             '<@(_outputs)',
           ],
           'includes': [
             '../build/util/version.gypi',
           ],
         },
       ],
     },
@@ skipping 238 matching lines @@
             'cast_shell_core',
           ],
           'sources': [
             'app/cast_main.cc',
           ],
         },
       ],  # end of targets
     }],
   ],  # end of conditions
 }