Add third_party/android_data_chart for data chart widget.

Add third_party/android_data_chart for data chart widget.

This adds a new third_party directory, android_data_chart, which
contains the data usage chart UI widget from Android's Settings app. The
widget shows a graph of how much data the user has used and saved over
time.

BUG=428885
R=bengr@chromium.org, cpu@chromium.org, dannyb@google.com, tedchoc@chromium.org

Committed: https://crrev.com/6703c21ca0b048bb1955da39e0c73b033d023bae
Cr-Commit-Position: refs/heads/master@{#314251}

[newt (away), 2015-01-23 00:23:27]

newt@chromium.org changed reviewers:
+ cpu@chromium.org, tedchoc@chromium.org

[newt (away), 2015-01-23 00:23:28]

+cpu for adding a new third_party directory
+tedchoc for Java/xml files

[Ted C, 2015-01-23 19:48:37]

lgtm

android_snippets seems like an odd name, but I can't think of anything better so
carry on.

https://codereview.chromium.org/866813004/diff/80001/third_party/android_snip...
File third_party/android_snippets/LICENSE (right):

https://codereview.chromium.org/866813004/diff/80001/third_party/android_snip...
third_party/android_snippets/LICENSE:1: Which license do I put here?
I think just an upload of your driver's should suffice.

[cpu_(ooo_6.6-7.5), 2015-01-23 23:58:31]

definitely a bad name, Until I saw ted comment I thought it was a "snippets"
feature.

Please try a better name. "android_misc" is my suggestion, we seem to have a few
"misc" directories.

[newt (away), 2015-01-24 00:14:26]

newt@chromium.org changed reviewers:
+ bengr@chromium.org

[newt (away), 2015-01-24 00:14:26]

+bengr, the originator of these files in Chromium

[newt (away), 2015-01-24 00:25:41]

I renamed it to android_misc as suggested. I agree that's a clearer name. Thanks
for idea.

[cpu_(ooo_6.6-7.5), 2015-01-26 19:15:01]

ok i agree we can add this, now is a matter of following
http://www.chromium.org/developers/adding-3rd-party-libraries

ping me when done for final ACK.

[bengr, 2015-01-26 19:25:00]

lgtm. I know this is more or less copied from AOSP, but ideally it would follow
Chromium style. Practically all of my comments are about that. Feel free to
ignore if you disagree.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File third_party/android_misc/OWNERS (right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/OWNERS:2: bauerb@chromium.org
Perhaps I should be an owner of this code?

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartAxis.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartAxis.java:28:

Remove blank line.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartAxis.java:53:

Remove blank line.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:88:
// tell everyone about our axis
Remove this comment.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:120:
* Update {@link #mVert} to show data from {@link NetworkStatsHistory}.
Updates

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:125:
// always show known data and policy lines
// Show known data and policy lines always.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:132:
// only invalidate when vertMax actually changed
Invalidate only when vertMax actually changed.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:135:

Remove blank line.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:137:

Remove blank line.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:175:
* Set the exact time range that should be displayed, updating how
Sets

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:193:
|| visibleEnd != end + timeZoneOffset) {
Move || up one line and align visibleEnd to visibleEnd on 191

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:217:
// prefer showing primary range on detail series, when available
Prefer ... available.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:299:
// TODO: convert to better string
Remove.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:309:
// tick mark for first day of each week
// Add a tick mark for the first day of each week.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:331:
// time axis never adjusts
// The time axis never adjusts.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:379:
// derived polynomial fit to make lower values more visible
Use a derived polynomial fit to make the lower values more visible.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:410:
unit = "MB";  // TODO: res.getText(R.string.origin_settings_storage_mbytes);
Make these TODOs bengr.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:439:
// target about 16 ticks on screen, rounded to nearest power of 2
Target .. 2.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:478:
// NOTE: borrowed from Hashtable.roundUpToPowerOfTwo()
Borrowed .. Two().

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:480:
i--; // If input is a power of two, shift its high-order bit right
right.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:145:
* Set the range to paint with {@link #mPaintFill}, leaving the remaining
Sets

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:161:
* Erase any existing {@link Path} and generate series outline based on
Erases ... generates

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:189:
// TODO: count fractional data from first bucket crossing start;
// TODO(bengr): Count

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:207:
// skip until we find first stats on screen
Skip until the first stats are found on screen.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:210:
// increment by current bucket total
Imcrement .. total.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:217:
// gap in buckets; line to start of current bucket
Gap .. bucket.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:222:
// always draw to end of current bucket
Always .. bucket.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:231:
// when data falls short, extend to requested end time
When .. time.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:246:
// drop to bottom of graph from current location
Drop .. location.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartView.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartView.java:113:
// series are always laid out to fill entire graph area
Series .. area.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartView.java:114:
// TODO: handle scrolling for series larger than content area
Remove TODO and instead say:

// Scrolling is not supported for series larger than the content area.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:40:
public class NetworkStats implements Parcelable {
Remove blank line.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:237:
* Return specific stats entry.
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:258:
* Return age of this {@link NetworkStats} object with respect to
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:287:
* Combine given values with an existing row, or create a new row if
Combines

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:307:
* Combine all values from another {@link NetworkStats} into this object.
Combines

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:335:
* Find first stats index that matches the requested parameters.
Finds

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:348:
* Find first stats index that matches the requested parameters, starting
Finds

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:374:
* Splice in {@link #operations} from the given {@link NetworkStats} based
Splices

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:390:
* Return list of unique interfaces known by this data structure.
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:403:
* Return list of unique UIDs known by this data structure.
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:420:
* Return total bytes represented by this snapshot object, usually used when
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:429:
* Return total of all fields represented by this snapshot object.
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:436:
* Return total of all fields represented by this snapshot object matching
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:444:
* Return total of all fields represented by this snapshot object matching
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:452:
* Return total of all fields represented by this snapshot object matching
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:490:
* Subtract the given {@link NetworkStats}, effectively leaving the delta
Subtracts

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:499:
* Subtract the two given {@link NetworkStats} objects, returning the delta
Subtracts

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:516:
// result will have our rows, and elapsed time between snapshots
Result .. snapshots.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:562:
* Return total statistics grouped by {@link #iface}; doesn't mutate the
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:575:
// skip specific tags, since already counted in TAG_NONE
Skip .. TAG_NONE.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:590:
* Return total statistics grouped by {@link #uid}; doesn't mutate the
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:602:
// skip specific tags, since already counted in TAG_NONE
Skip .. TAG_NONE.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:625:
* Return all rows except those attributed to the requested UID; doesn't
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:660:
* Return text description of {@link #set} value.
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStats.java:676:
* Return text description of {@link #tag} value.
Returns

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:236:
* Return total bytes represented by this history.
Returns

Here and below.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:287:
* Record that data traffic occurred in the given time range. Will
Records

Here and below.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:311:
// create any buckets needed by this range
Create .. range.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:314:
// distribute data usage into buckets
Distribute .. buckets.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:321:
// bucket is older than record; we're finished
// Finished because bucket is older than record.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:323:
// bucket is newer than record; keep looking
// Keep looking because bucket is newer than record.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:329:
// integer math each time is faster than floating point
Integer .. point.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:383:
* Ensure that buckets exist for given time range, creating as needed.
Ensures

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:391:
// try finding existing bucket
// Try to find an existing bucket.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:394:
// bucket missing, create and insert
// The bucket is missing. Create one and insert it.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:401:
* Insert new bucket at requested index and starting time.
Inserts

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:404:
// create more buckets when needed
Creates .. needed.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:416:
// create gap when inserting bucket in middle
Create .. middle.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:441:
* Remove buckets older than requested cutoff.
Removes

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:450:
// cutoff happens before or during this bucket; everything before
The cutoff

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/NetworkStatsHistory.java:498:
// bucket is older than request; we're finished
Fix all comments to be complete sentences.

[newt (away), 2015-01-27 02:35:53]

bengr: I addressed your comments about things other than style. As for style,
I'd rather change the code less rather than more, in case we want pull in
changes from upstream at some point. Does that sound OK?

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File third_party/android_misc/OWNERS (right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/OWNERS:2: bauerb@chromium.org
On 2015/01/26 19:24:57, bengr wrote:
> Perhaps I should be an owner of this code?

Done.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:299:
// TODO: convert to better string
On 2015/01/26 19:24:57, bengr wrote:
> Remove.

Done.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:410:
unit = "MB";  // TODO: res.getText(R.string.origin_settings_storage_mbytes);
On 2015/01/26 19:24:57, bengr wrote:
> Make these TODOs bengr.

Done.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:189:
// TODO: count fractional data from first bucket crossing start;
On 2015/01/26 19:24:58, bengr wrote:
> // TODO(bengr): Count

Done.

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
File
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartView.java
(right):

https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartView.java:114:
// TODO: handle scrolling for series larger than content area
On 2015/01/26 19:24:58, bengr wrote:
> Remove TODO and instead say:
> 
> // Scrolling is not supported for series larger than the content area.

Done.

[bengr, 2015-01-27 19:04:38]

On 2015/01/27 02:35:53, newt wrote:
> bengr: I addressed your comments about things other than style. As for style,
> I'd rather change the code less rather than more, in case we want pull in
> changes from upstream at some point. Does that sound OK?
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
> File third_party/android_misc/OWNERS (right):
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
> third_party/android_misc/OWNERS:2: mailto:bauerb@chromium.org
> On 2015/01/26 19:24:57, bengr wrote:
> > Perhaps I should be an owner of this code?
> 
> Done.
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
> File
>
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java
> (right):
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
>
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:299:
> // TODO: convert to better string
> On 2015/01/26 19:24:57, bengr wrote:
> > Remove.
> 
> Done.
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
>
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java:410:
> unit = "MB";  // TODO: res.getText(R.string.origin_settings_storage_mbytes);
> On 2015/01/26 19:24:57, bengr wrote:
> > Make these TODOs bengr.
> 
> Done.
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
> File
>
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java
> (right):
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
>
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java:189:
> // TODO: count fractional data from first bucket crossing start;
> On 2015/01/26 19:24:58, bengr wrote:
> > // TODO(bengr): Count
> 
> Done.
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
> File
>
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartView.java
> (right):
> 
>
https://codereview.chromium.org/866813004/diff/120001/third_party/android_mis...
>
third_party/android_misc/java/src/org/chromium/third_party/android/datausagechart/ChartView.java:114:
> // TODO: handle scrolling for series larger than content area
> On 2015/01/26 19:24:58, bengr wrote:
> > Remove TODO and instead say:
> > 
> > // Scrolling is not supported for series larger than the content area.
> 
> Done.

lgtm.

[newt (away), 2015-01-28 23:19:04]

I've renamed this from android_misc to android_data_chart per the suggestion of
the open source reviewer. The scope of the directory is now much more limited.

[Ted C, 2015-01-30 18:17:43]

On 2015/01/28 23:19:04, newt wrote:
> I've renamed this from android_misc to android_data_chart per the suggestion
of
> the open source reviewer. The scope of the directory is now much more limited.

lgtm still

[newt (away), 2015-01-30 20:05:00]

got lgtm from security@chromium.org

[Daniel Berlin, 2015-01-30 22:02:08]

dannyb@google.com changed reviewers:
+ dannyb@google.com

[Daniel Berlin, 2015-01-30 22:02:09]

LGTM for OSTPR

[newt (away), 2015-01-30 22:17:00]

cpu: PTAL for final approval

[cpu_(ooo_6.6-7.5), 2015-02-03 00:03:20]

lgtm

[newt (away), 2015-02-03 00:09:37]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-02-03 00:10:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866813004/180001

[commit-bot: I haz the power, 2015-02-03 02:11:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 02:11:43]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (None)

[newt (away), 2015-02-03 02:45:31]

Committed patchset #10 (id:180001) to pending queue manually as
603a3876956a6f12b4005fe67028548d881e2eaa (presubmit successful).

[commit-bot: I haz the power, 2015-02-03 02:46:31]

Patchset 10 (id:??) landed as
https://crrev.com/6703c21ca0b048bb1955da39e0c73b033d023bae
Cr-Commit-Position: refs/heads/master@{#314251}