chrome/browser/web_dev_style/html_checker.py - Issue 866753002: Fix the 'for' attribute check in presubmit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_dev_style/html_checker.py

Issue 866753002: Fix the 'for' attribute check in presubmit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/web_dev_style/html_checker.py

diff --git a/chrome/browser/web_dev_style/html_checker.py b/chrome/browser/web_dev_style/html_checker.py

index 0addcd71ad623a3b108c4ca47349e640f61312a6..408ff909bd0cef2d3cfdc8cd7bb9b226c4d001dc 100644

--- a/chrome/browser/web_dev_style/html_checker.py

+++ b/chrome/browser/web_dev_style/html_checker.py

@@ -17,7 +17,7 @@ class HtmlChecker(object):

def LabelCheck(self, line_number, line):

return regex_check.RegexCheck(self.input_api.re, line_number, line,

- "(for=)",

+ r"(?:^|\s)(for=)",

Dan Beam 2015/01/22 16:39:17 can you please add a test for this (mainly so I kn

"Avoid 'for' attribute on <label>. Place the input within the <label>, "

"or use aria-labelledby for <select>.")

« no previous file with comments | « no previous file | no next file » | no next file with comments »