Issue 866733002: Add FakeAffiliationFetcher and factory.

Issue 866733002: Add FakeAffiliationFetcher and factory. (Closed)

Created:
5 years, 11 months ago by engedy

Modified:
5 years, 11 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add FakeAffiliationFetcher and factory. BUG=437865 Committed: https://crrev.com/a6d3a968394fcfe080a6185819e725a698a9e7be Cr-Commit-Position: refs/heads/master@{#312625}

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -0 lines)			Patch
M	components/password_manager.gypi	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	components/password_manager/core/browser/BUILD.gn	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	components/password_manager/core/browser/affiliation_fetcher.h	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	components/password_manager/core/browser/affiliation_fetcher.cc	View	1 2	3 chunks	+13 lines, -0 lines	0 comments	Download
A	components/password_manager/core/browser/fake_affiliation_fetcher.h	View	1 2	1 chunk	+78 lines, -0 lines	0 comments	Download
A	components/password_manager/core/browser/fake_affiliation_fetcher.cc	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download
A	components/password_manager/core/browser/test_affiliation_fetcher_factory.h	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download

Total messages: 10 (3 generated)

vabr (Chromium)

We just spoke offline, but I'm publishing this optional comment as well, as I did ...

5 years, 11 months ago (2015-01-22 14:27:04 UTC) #4

vabr (Chromium)

And LGTM, because my feedback was just nitpicking. :)

5 years, 11 months ago (2015-01-22 14:27:28 UTC) #5

engedy

I have renamed the factory to TestAffiliationFetcherFactory to indicate that it should only be used ...

5 years, 11 months ago (2015-01-22 14:41:14 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866733002/80001

5 years, 11 months ago (2015-01-22 14:43:42 UTC) #8

commit-bot: I haz the power

5 years, 11 months ago (2015-01-22 15:52:32 UTC) #10

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/a6d3a968394fcfe080a6185819e725a698a9e7be
Cr-Commit-Position: refs/heads/master@{#312625}