Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 866723005: Revert of Update SSL/malware/net error interstitial design (Closed)

Created:
5 years, 11 months ago by dconnelly
Modified:
5 years, 11 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update SSL/malware/net error interstitial design (patchset #10 id:180001 of https://codereview.chromium.org/865943002/) Reason for revert: ErrorPageTests are failing on Linux ChromiumOS: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55305 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55306 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55307 Original issue's description: > + On small screens the navigation buttons are anchored to the bottom of the screen. > + Tweaks to the text colour > + Change button styling of safe browsing page > > BUG=422882 > > Committed: https://crrev.com/7ee5b21903f8a466e8f8e995e62354deceb987f0 > Cr-Commit-Position: refs/heads/master@{#313280} TBR=arv@chromium.org,felt@chromium.org,edwardjung@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=422882 Committed: https://crrev.com/a535eb28d8d33d58767211ecb52486e21017dbfc Cr-Commit-Position: refs/heads/master@{#313288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -505 lines) Patch
M chrome/browser/resources/security_warnings/interstitial_v2.css View 10 chunks +15 lines, -372 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.html View 1 chunk +17 lines, -22 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.js View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/browser/resources/security_warnings/interstitial_v2_mobile.js View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/resources/security_warnings/safe_browsing.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/resources/neterror.css View 6 chunks +7 lines, -12 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 2 chunks +54 lines, -54 lines 0 comments Download
M chrome/renderer/resources/neterror.js View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dconnelly
Created Revert of Update SSL/malware/net error interstitial design
5 years, 11 months ago (2015-01-27 16:40:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866723005/1
5 years, 11 months ago (2015-01-27 16:41:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 16:42:38 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 16:43:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a535eb28d8d33d58767211ecb52486e21017dbfc
Cr-Commit-Position: refs/heads/master@{#313288}

Powered by Google App Engine
This is Rietveld 408576698