src/arm/lithium-codegen-arm.cc - Issue 866723002: Treat pointers in optimized code as strong before all weak dependencies are registered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 866723002: Treat pointers in optimized code as strong before all weak dependencies are registered. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 26be2413084e0f1482be7cde94740f5a851908e4..7c2ba974eb2993f12466a3ef5c5cc0b00c8b1acf 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -61,7 +61,6 @@ void LCodeGen::FinishCode(Handle<Code> code) {

DCHECK(is_done());

code->set_stack_slots(GetStackSlotCount());

code->set_safepoint_table_offset(safepoints_.GetCodeOffset());

- if (code->is_optimized_code()) RegisterWeakObjectsInOptimizedCode(code);

PopulateDeoptimizationData(code);

}

« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | src/lithium.cc » ('J')