Treat pointers in optimized code as strong before all weak dependencies are registered.

Treat pointers in optimized code as strong before all weak dependencies are registered.

This prevents GC from observing code objects with out-of-sync weak dependencies.

BUG=v8:3823
LOG=N

Committed: https://crrev.com/40973187925838554e0dc25701ffda38f0e19db2
Cr-Commit-Position: refs/heads/master@{#26225}

[ulan, 2015-01-22 13:53:52]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2015-01-22 13:53:53]

PTAL

https://codereview.chromium.org/866723002/diff/1/src/lithium.cc
File src/lithium.cc (right):

https://codereview.chromium.org/866723002/diff/1/src/lithium.cc#newcode416
src/lithium.cc:416: static void AddWeakObjectToCodeDependency(Isolate* isolate,
Move these functions from src/lithium-codegen.cc.

https://codereview.chromium.org/866723002/diff/1/src/lithium.cc#newcode467
src/lithium.cc:467: code->set_can_have_weak_objects(true);
The line above is the only change. After this point all weak-dependencies are
registered, so GC can start treating the pointers as weak.

[Hannes Payer (out of office), 2015-01-22 14:39:00]

lgtm

https://codereview.chromium.org/866723002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/866723002/diff/1/src/objects-inl.h#newcode4861
src/objects-inl.h:4861: DCHECK(kind() == OPTIMIZED_FUNCTION);
Let's DCHECk !is_turbofanned().

[ulan, 2015-01-22 15:01:16]

Thanks, landing.

https://codereview.chromium.org/866723002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/866723002/diff/1/src/objects-inl.h#newcode4861
src/objects-inl.h:4861: DCHECK(kind() == OPTIMIZED_FUNCTION);
On 2015/01/22 14:38:59, Hannes Payer wrote:
> Let's DCHECk !is_turbofanned().

Added a check that turbofanned code cannot have weak objects in object.h.

[ulan, 2015-01-22 15:01:34]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2015-01-22 15:02:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866723002/40001

[commit-bot: I haz the power, 2015-01-22 15:30:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-22 15:31:13]

Patchset 3 (id:??) landed as
https://crrev.com/40973187925838554e0dc25701ffda38f0e19db2
Cr-Commit-Position: refs/heads/master@{#26225}