chrome/browser/chromeos/accessibility/speech_monitor.cc - Issue 866713002: Reland: Reenable oobe spoken feedback test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/accessibility/speech_monitor.cc

Issue 866713002: Reland: Reenable oobe spoken feedback test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rewrite OOBE test to be based on LoginManagerTest and not assume initial speech, git cl format. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/accessibility/speech_monitor.cc

diff --git a/chrome/browser/chromeos/accessibility/speech_monitor.cc b/chrome/browser/chromeos/accessibility/speech_monitor.cc

index dabc8d74f5ea1bb65db21cb1e5652564b5e0c9e2..fce3ea8c28e666189eef3cd6fb70ccc4f5d02232 100644

--- a/chrome/browser/chromeos/accessibility/speech_monitor.cc

+++ b/chrome/browser/chromeos/accessibility/speech_monitor.cc

@@ -73,6 +73,7 @@ std::string SpeechMonitor::error() {

void SpeechMonitor::WillSpeakUtteranceWithVoice(const Utterance* utterance,

const VoiceData& voice_data) {

+ VLOG(0) << "Speaking " << utterance->text();

David Tseng 2015/01/27 18:16:45 nit: remove

dmazzoni 2015/01/27 18:38:44 I'm okay with leaving it as a VLOG, but I learned

utterance_queue_.push_back(utterance->text());

if (loop_runner_.get())

loop_runner_->Quit();