Reland: Reenable oobe spoken feedback test.

Reland: Reenable oobe spoken feedback test.

The test was disabled because it was flaky.  This CL tries to address that
and reenables the test.

This relands the previous attempt which was still flaky on slow enough environments (such as the memory bots).

BUG=346797
R=dtseng@chromium.org

Committed: https://crrev.com/e03f042d1c76262248e42334b1d0326b0e4319e7
Cr-Commit-Position: refs/heads/master@{#313467}

Committed: https://crrev.com/d329c7f093c4c7af682e514eeb2bfb3148342575
Cr-Commit-Position: refs/heads/master@{#314298}

[dmazzoni, 2015-01-22 14:33:44]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-01-22 14:33:44]

Thanks for working on this! Looks like it's still failing on one bot, though. I
think there's actually a race condition and the same control doesn't always get
focus. I've even seen that in person, and I'm not even sure ChromeVox is related
to the race condition, it may just affect whether or not the first combo box
actually has focus or not.

In an earlier version of the test we tried to keep tabbing until we hit a known
control, maybe we need to do something along those lines?

Alternatively, add a fix to the oobe code itself that forces a certain control
to get focus?

[Peter Lundblad, 2015-01-22 14:38:49]

Yes, I am debugging.  Of course it doesn't fail locally...
I really want to get to the bottom of this now.


@David: hold of reviewing until this is fixed please.



dmazzoni@chromium.org writes:
> Thanks for working on this! Looks like it's still failing on one bot,  
> though. I
> think there's actually a race condition and the same control doesn't always  
> get
> focus. I've even seen that in person, and I'm not even sure ChromeVox is  
> related
> to the race condition, it may just affect whether or not the first combo box
> actually has focus or not.
> 
> In an earlier version of the test we tried to keep tabbing until we hit a  
> known
> control, maybe we need to do something along those lines?
> 
> Alternatively, add a fix to the oobe code itself that forces a certain  
> control
> to get focus?
> 
> 
> https://codereview.chromium.org/866713002/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-01-22 14:44:04]

Yeah, at one point I ran it 100x in a script and it didn't fail locally
once, but it failed on the bots. Frustrating.

On Thu, Jan 22, 2015 at 6:38 AM, <plundblad@chromium.org> wrote:

> Yes, I am debugging.  Of course it doesn't fail locally...
> I really want to get to the bottom of this now.
>
>
> @David: hold of reviewing until this is fixed please.
>
>
>
> dmazzoni@chromium.org writes:
> > Thanks for working on this! Looks like it's still failing on one bot,
> > though. I
> > think there's actually a race condition and the same control doesn't
> always
> > get
> > focus. I've even seen that in person, and I'm not even sure ChromeVox is
> > related
> > to the race condition, it may just affect whether or not the first combo
> box
> > actually has focus or not.
> >
> > In an earlier version of the test we tried to keep tabbing until we hit a
> > known
> > control, maybe we need to do something along those lines?
> >
> > Alternatively, add a fix to the oobe code itself that forces a certain
> > control
> > to get focus?
> >
> >
> > https://codereview.chromium.org/866713002/
>
> --
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2015-01-22 15:40:42]

Looking at the latest failure with tts logging haccked in, it turns out that
the OOBE flow is different when the machine lacks HID devices which the
bots presumably do.  Will compensate for that in the test.

Thanks,
//Peter

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2015-01-27 17:50:05]

PTAL

Basically rewrote this test, it doesn't seem flaky locally and succeeds on the
bot (fingers crossed). Ready for another look.

//Peter

[David Tseng, 2015-01-27 18:16:45]

lgtm

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/accessibility/speech_monitor.cc (right):

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/speech_monitor.cc:76: VLOG(0) << "Speaking
" << utterance->text();
nit: remove

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
(right):

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:598: // We
expect to be in the language select dropdown for this test to wwork,
nit: new line above

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:614:
LOG(ERROR) << "Got select your keyboard";
nit: remove

[dmazzoni, 2015-01-27 18:38:44]

lgtm

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/accessibility/speech_monitor.cc (right):

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/speech_monitor.cc:76: VLOG(0) << "Speaking
" << utterance->text();
On 2015/01/27 18:16:45, David Tseng wrote:
> nit: remove

I'm okay with leaving it as a VLOG, but I learned recently that VLOG(0) is
always on when logging is on, so it should probably be VLOG(1).

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
(right):

https://codereview.chromium.org/866713002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:598: // We
expect to be in the language select dropdown for this test to wwork,
On 2015/01/27 18:16:45, David Tseng wrote:
> nit: new line above

Also wwork -> work

[Peter Lundblad, 2015-01-28 08:46:48]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2015-01-28 08:47:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866713002/60001

[commit-bot: I haz the power, 2015-01-28 09:38:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-28 09:40:08]

Patchset 4 (id:??) landed as
https://crrev.com/e03f042d1c76262248e42334b1d0326b0e4319e7
Cr-Commit-Position: refs/heads/master@{#313467}

[dconnelly, 2015-01-28 13:28:24]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/884643003/ by dconnelly@chromium.org.

The reason for reverting is: Still failing :(

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20....

[Peter Lundblad, 2015-02-03 08:53:11]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2015-02-03 08:53:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866713002/100001

[commit-bot: I haz the power, 2015-02-03 09:30:14]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-03 09:33:31]

Patchset 6 (id:??) landed as
https://crrev.com/d329c7f093c4c7af682e514eeb2bfb3148342575
Cr-Commit-Position: refs/heads/master@{#314298}

[David Tseng, 2015-02-03 19:13:24]

This is still failing for me (on linux_chromium_chromeos_asan_rel_ng).

example:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

On Tue, Feb 3, 2015 at 1:33 AM, <commit-bot@chromium.org> wrote:

> Patchset 6 (id:??) landed as
> https://crrev.com/d329c7f093c4c7af682e514eeb2bfb3148342575
> Cr-Commit-Position: refs/heads/master@{#314298}
>
>
> https://codereview.chromium.org/866713002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.