Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: runtime/observatory/lib/src/app/application.dart

Issue 866663003: Add a working command line debugger to Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/debugger.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/application.dart
diff --git a/runtime/observatory/lib/src/app/application.dart b/runtime/observatory/lib/src/app/application.dart
index 447e8db1e0b4e627a187cd292d85dbd734ebe2c1..c5413c9dd03b5a44a7f38572db10126b725bb5e8 100644
--- a/runtime/observatory/lib/src/app/application.dart
+++ b/runtime/observatory/lib/src/app/application.dart
@@ -65,7 +65,11 @@ class ObservatoryApplication extends Observable {
void _onEvent(ServiceEvent event) {
switch(event.eventType) {
case 'IsolateCreated':
- // vm.reload();
+ // Ignore for now.
+ break;
+
+ case 'IsolateResumed':
+ event.isolate.pauseEvent = null;
break;
case 'IsolateShutdown':
@@ -73,7 +77,11 @@ class ObservatoryApplication extends Observable {
// What if there are hundreds of them? Coalesce multiple
// shutdown events into one notification?
removePauseEvents(event.isolate);
- // vm.reload();
+
+ // TODO(turnidge): Reload the isolate for now in case it is
+ // paused. We may need to distinguish an IsolateShutdown
+ // event from a "paused at isolate shutdown" event.
+ event.isolate.reload();
break;
case 'BreakpointResolved':
@@ -83,6 +91,7 @@ class ObservatoryApplication extends Observable {
case 'BreakpointReached':
case 'IsolateInterrupted':
case 'ExceptionThrown':
+ event.isolate.pauseEvent = event;
removePauseEvents(event.isolate);
notifications.add(event);
break;
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/debugger.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698