Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: runtime/observatory/test/debugging_test.dart

Issue 866663003: Add a working command line debugger to Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/test/debugging_test.dart
diff --git a/runtime/observatory/test/debugging_test.dart b/runtime/observatory/test/debugging_test.dart
index 7fa589134c8000b1c7cbdf79b23ca1e81533bc99..ac6b48c720b8db25aaed46bbcf62eef0c4f05380 100644
--- a/runtime/observatory/test/debugging_test.dart
+++ b/runtime/observatory/test/debugging_test.dart
@@ -46,12 +46,12 @@ var tests = [
isolate.vm.events.stream.listen((ServiceEvent event) {
if (event.eventType.startsWith('Breakpoint')) {
events.add(event);
- }
- if (events.length == 2) {
- expect(events[0].eventType, equals('BreakpointResolved'));
- expect(events[1].eventType, equals('BreakpointReached'));
- print('Breakpoint reached');
- completer.complete();
+ if (events.length == 2) {
+ expect(events[0].eventType, equals('BreakpointResolved'));
+ expect(events[1].eventType, equals('BreakpointReached'));
+ print('Breakpoint reached');
+ completer.complete();
+ }
}
});
@@ -63,8 +63,7 @@ var tests = [
expect(m.type, equals('Breakpoint'));
expect(m['location']['script'].id, equals(script.id));
expect(m['location']['tokenPos'], equals(51));
- expect(isolate.breakpoints.type, equals('BreakpointList'));
- expect(isolate.breakpoints['breakpoints'].length, equals(1));
+ expect(isolate.breakpoints.length, equals(1));
return completer.future; // Wait for breakpoint events.
});
});
@@ -87,9 +86,9 @@ var tests = [
isolate.vm.events.stream.listen((ServiceEvent event) {
if (event.eventType.startsWith('Breakpoint')) {
expect(event.eventType, equals('BreakpointReached'));
+ print('Breakpoint reached');
+ completer.complete();
}
- print('Breakpoint reached');
- completer.complete();
});
return isolate.stepInto().then((isolate) {
@@ -108,10 +107,10 @@ var tests = [
// Remove breakpoint
(Isolate isolate) {
- expect(isolate.breakpoints['breakpoints'].length, equals(1));
- var bpt = isolate.breakpoints['breakpoints'][0];
+ expect(isolate.breakpoints.length, equals(1));
+ var bpt = isolate.breakpoints[0];
return isolate.removeBreakpoint(bpt).then((_) {
- expect(isolate.breakpoints['breakpoints'].length, equals(0));
+ expect(isolate.breakpoints.length, equals(0));
});
},

Powered by Google App Engine
This is Rietveld 408576698