c++11: Allow in-class member initialization

c++11: Allow in-class member initialization

Move this feature to the allowed section.
Try using it in timer_unittest.cc

R=thakis@chromium.org

Committed: https://crrev.com/42a14e86295b7cc7a77618443a6de28da4182672
Cr-Commit-Position: refs/heads/master@{#312621}

[Nico, 2015-01-22 08:02:16]

Can you add a link to the relevant section in the Google style guide too?
On Jan 21, 2015 10:43 PM, <hashimoto@chromium.org> wrote:

> Reviewers: Nico,
>
> Description:
> c++11: Allow in-class member initialization
>
> Move this feature to the allowed section.
> Try using it in timer_unittest.cc
>
> R=thakis@chromium.org
>
> Please review this at https://codereview.chromium.org/866663002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+15, -19 lines):
>   M base/timer/timer_unittest.cc
>   M styleguide/c++/c++11.html
>
>
> Index: base/timer/timer_unittest.cc
> diff --git a/base/timer/timer_unittest.cc b/base/timer/timer_unittest.cc
> index 1cbccd1626d558d912a267212325856aa3eff86c..
> 7213b809b7b0251d2a8876687866f9ec2b1147fd 100644
> --- a/base/timer/timer_unittest.cc
> +++ b/base/timer/timer_unittest.cc
> @@ -189,10 +189,6 @@ void
RunTest_RepeatingTimer_Cancel(base::MessageLoop::Type
> message_loop_type,
>
>  class DelayTimerTarget {
>   public:
> -  DelayTimerTarget()
> -      : signaled_(false) {
> -  }
> -
>    bool signaled() const { return signaled_; }
>
>    void Signal() {
> @@ -201,7 +197,7 @@ class DelayTimerTarget {
>    }
>
>   private:
> -  bool signaled_;
> +  bool signaled_ = false;
>  };
>
>  void RunTest_DelayTimer_NoCall(base::MessageLoop::Type
> message_loop_type) {
> Index: styleguide/c++/c++11.html
> diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html
> index 6ca2eb8555a9c76aa5141af9e03cf3c891342486..
> 9da3fa344a482e55b7a3979c2ed52a83f0dcbe6f 100644
> --- a/styleguide/c++/c++11.html
> +++ b/styleguide/c++/c++11.html
> @@ -173,6 +173,20 @@ Local types, types without linkage and unnamed types
> as template arguments</a></
>  </tr>
>
>  <tr>
> +<td>Non-Static Class Member Initializers</td>
> +<td>
> +<code>
> +class C {<br />
> +  <i>type</i> <i>var</i> = <i>value</i>;<br/>
> +  C()  // copy-initializes <i>var</i><br/>
> +</code>
> +<td>Allows non-static class members to be initialized at their
> definitions (outside constructors)</td>
> +<td><a href="http://en.cppreference.com/w/cpp/language/data_members">
> +Non-static data members</a></td>
> +<td><a href="https://groups.google.com/a/chromium.org/forum/#!
> topic/chromium-dev/zqB-DySA4V0">Discussion thread</a></td>
> +</tr>
> +
> +<tr>
>  <td>Null Pointer Constant</td>
>  <td><code>nullptr</code></td>
>  <td>Declares a type-safe null pointer</td>
> @@ -434,20 +448,6 @@ std::exception</a></td>
>  </tr>
>
>  <tr>
> -<td>Non-Static Class Member Initializers</td>
> -<td>
> -<code>
> -class C {<br />
> -  <i>type</i> <i>var</i> = <i>value</i>;<br/>
> -  C()  // copy-initializes <i>var</i><br/>
> -</code>
> -<td>Allows non-static class members to be initialized at their
> definitions (outside constructors)</td>
> -<td><a href="http://en.cppreference.com/w/cpp/language/data_members">
> -Non-static data members</a></td>
> -<td><a href="https://groups.google.com/a/chromium.org/forum/#!
> topic/chromium-dev/zqB-DySA4V0">Discussion thread</a></td>
> -</tr>
> -
> -<tr>
>  <td>Union Class Members</td>
>  <td><code>union <i>name</i> { <i>class</i> <i>var</i>}</code></td>
>  <td>Allows class type members</td>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hashimoto, 2015-01-22 08:22:33]

On 2015/01/22 08:02:16, Nico wrote:
> Can you add a link to the relevant section in the Google style guide too?
Sure, done.
> On Jan 21, 2015 10:43 PM, <mailto:hashimoto@chromium.org> wrote:
> 
> > Reviewers: Nico,
> >
> > Description:
> > c++11: Allow in-class member initialization
> >
> > Move this feature to the allowed section.
> > Try using it in timer_unittest.cc
> >
> > mailto:R=thakis@chromium.org
> >
> > Please review this at https://codereview.chromium.org/866663002/
> >
> > Base URL: https://chromium.googlesource.com/chromium/src.git@master
> >
> > Affected files (+15, -19 lines):
> >   M base/timer/timer_unittest.cc
> >   M styleguide/c++/c++11.html
> >
> >
> > Index: base/timer/timer_unittest.cc
> > diff --git a/base/timer/timer_unittest.cc b/base/timer/timer_unittest.cc
> > index 1cbccd1626d558d912a267212325856aa3eff86c..
> > 7213b809b7b0251d2a8876687866f9ec2b1147fd 100644
> > --- a/base/timer/timer_unittest.cc
> > +++ b/base/timer/timer_unittest.cc
> > @@ -189,10 +189,6 @@ void
> RunTest_RepeatingTimer_Cancel(base::MessageLoop::Type
> > message_loop_type,
> >
> >  class DelayTimerTarget {
> >   public:
> > -  DelayTimerTarget()
> > -      : signaled_(false) {
> > -  }
> > -
> >    bool signaled() const { return signaled_; }
> >
> >    void Signal() {
> > @@ -201,7 +197,7 @@ class DelayTimerTarget {
> >    }
> >
> >   private:
> > -  bool signaled_;
> > +  bool signaled_ = false;
> >  };
> >
> >  void RunTest_DelayTimer_NoCall(base::MessageLoop::Type
> > message_loop_type) {
> > Index: styleguide/c++/c++11.html
> > diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html
> > index 6ca2eb8555a9c76aa5141af9e03cf3c891342486..
> > 9da3fa344a482e55b7a3979c2ed52a83f0dcbe6f 100644
> > --- a/styleguide/c++/c++11.html
> > +++ b/styleguide/c++/c++11.html
> > @@ -173,6 +173,20 @@ Local types, types without linkage and unnamed types
> > as template arguments</a></
> >  </tr>
> >
> >  <tr>
> > +<td>Non-Static Class Member Initializers</td>
> > +<td>
> > +<code>
> > +class C {<br />
> > +  <i>type</i> <i>var</i> = <i>value</i>;<br/>
> > +  C()  // copy-initializes <i>var</i><br/>
> > +</code>
> > +<td>Allows non-static class members to be initialized at their
> > definitions (outside constructors)</td>
> > +<td><a href="http://en.cppreference.com/w/cpp/language/data_members">
> > +Non-static data members</a></td>
> > +<td><a href="https://groups.google.com/a/chromium.org/forum/#!
> > topic/chromium-dev/zqB-DySA4V0">Discussion thread</a></td>
> > +</tr>
> > +
> > +<tr>
> >  <td>Null Pointer Constant</td>
> >  <td><code>nullptr</code></td>
> >  <td>Declares a type-safe null pointer</td>
> > @@ -434,20 +448,6 @@ std::exception</a></td>
> >  </tr>
> >
> >  <tr>
> > -<td>Non-Static Class Member Initializers</td>
> > -<td>
> > -<code>
> > -class C {<br />
> > -  <i>type</i> <i>var</i> = <i>value</i>;<br/>
> > -  C()  // copy-initializes <i>var</i><br/>
> > -</code>
> > -<td>Allows non-static class members to be initialized at their
> > definitions (outside constructors)</td>
> > -<td><a href="http://en.cppreference.com/w/cpp/language/data_members">
> > -Non-static data members</a></td>
> > -<td><a href="https://groups.google.com/a/chromium.org/forum/#!
> > topic/chromium-dev/zqB-DySA4V0">Discussion thread</a></td>
> > -</tr>
> > -
> > -<tr>
> >  <td>Union Class Members</td>
> >  <td><code>union <i>name</i> { <i>class</i> <i>var</i>}</code></td>
> >  <td>Allows class type members</td>
> >
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-01-22 14:13:50]

lgtm

[hashimoto, 2015-01-22 14:32:59]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2015-01-22 14:33:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866663002/20001

[commit-bot: I haz the power, 2015-01-22 15:22:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-22 15:22:56]

Patchset 2 (id:??) landed as
https://crrev.com/42a14e86295b7cc7a77618443a6de28da4182672
Cr-Commit-Position: refs/heads/master@{#312621}